Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kedro-datasets to match with kedro.extras.datasets #74

Merged
merged 8 commits into from
Nov 15, 2022

Conversation

SajidAlamQB
Copy link
Contributor

@SajidAlamQB SajidAlamQB commented Nov 14, 2022

Description

kedro-datasets is a bit out of date from kedro.extras.dataset, causing issues in kedro-org/kedro#2006 where linkcheck in CI would fail once kedro-dataset is copied to kedro.datasets.

Development notes

  • Copied all kedro.extras.datasets into kedro-datasets
  • Copied relevant tests that needed updating

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes

@SajidAlamQB SajidAlamQB self-assigned this Nov 14, 2022
Copy link
Contributor

@noklam noklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just for making sure the test pass temporarily? As we still have a couple of PRs opened we will need to sync again before we release.

I'll approve it anyway since we have to do this again after the new datasets PRs merged.

@SajidAlamQB
Copy link
Contributor Author

Is this just for making sure the test pass temporarily? As we still have a couple of PRs opened we will need to sync again before we release.

I'll approve it anyway since we have to do this again after the new datasets PRs merged.

Yes, this is just to ensure test passes for now we will need to do this again before release.

Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SajidAlamQB SajidAlamQB merged commit 8c04933 into main Nov 15, 2022
@SajidAlamQB SajidAlamQB deleted the feat/update-kedro_datasets branch November 15, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants