-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the documentations for kedro-datasets work on kedro #2006
Conversation
Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
…o test-dataset Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com> Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
…o test-dataset Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com> Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work @SajidAlamQB ! ⭐ The decision made in tech design really simplified the solution. Really well done on investigating all options and implementing it 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I couldn't build the docs on my machine from your branch because of various toolchain issues associated with tools like pyproj on my machine (which is a bit odd, as I've been building OK to date, but could be unrelated).
So I didn't verify the build myself locally (and the CI checks aren't returning success yet), but it looks sound to me from the perspective of what you've implemented. Nice work!
@astrojuanlu just tagging you in on this as a record of the decision-making about datasets API docs. |
Signed-off-by: SajidAlamQB 90610031+SajidAlamQB@users.noreply.github.com
Description
Since
kedro.extras.datasets
is moving to a separatekedro-datasets
package, how will our docs work for kedro-datasets and kedro?This PR will look to implement the solution outlined in the comment on issue: #1651 (comment).
kedro-datasets
andkedro
docs should remain together on RTD as they do now. The only difference is that the API docs forkedro-datsets
will appear underkedro.datasets
rather thankedro.extras.datasets
. All the document-building takes place on thekedro
repo.To achieve this we need the following flow when docs are built on
kedro
:kedro-datasets
files into adatasets
folder inkedro
(maybe clone just the relevant branch of the repo? Orpip install --no-deps -t
into the right directory is maybe easier?)make build-docs
on the kedro repo should then work as it does now to generate API docs for both kedro core and kedro datasetskedro-datasets
files should not remain on the kedro repo - they're just temporarily copied across for docs generationDevelopment notes
Notes on how to copy
kedro-datasets
tokedro
:To copy
kedro-datasets
main use this command:To copy
kedro-datasets
latest release use this command:After the technical design session, we decided to simplify the design solution by allowing
stable
andlatest
in RTD to be the same as the latest version ofkedro-datasets
. In the near future, we will move away from ReadTheDocs and sphinx, so we are happy to leave this as a stop-gap solution.kedro-datasets
latest release tokedro.datasets
inkedro
. The script is used bybuild-docs.sh
and.readthedocs.yml
so that both the CI and ReadTheDocs will build the correct documentation..readthedocs.yml
has hooks/build customisation that allows us to copy over the kedro-datasets before docs are built.Checklist
RELEASE.md
file