feat(datasets): create separate ibis.FileDataset
#842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepyaman
force-pushed
the
feat/datasets/ibis-filedataset
branch
2 times, most recently
from
fbcf8ff
to
814c514
Compare
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
deepyaman
force-pushed
the
feat/datasets/ibis-filedataset
branch
from
814c514
to
bdf4d3b
Compare
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
deepyaman
force-pushed
the
feat/datasets/ibis-filedataset
branch
2 times, most recently
from
0bfc761
to
2a633a2
Compare
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
deepyaman
force-pushed
the
feat/datasets/ibis-filedataset
branch
from
2a633a2
to
f45f408
Compare
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Refs: b7ff0c7 Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
deepyaman
force-pushed
the
feat/datasets/ibis-filedataset
branch
from
88f74cb
to
c8f076e
Compare
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
datajoely
reviewed
Sep 24, 2024
|
|
||
| @property | ||
| def connection(self) -> BaseBackend: | ||
| def hashable(value): |
There was a problem hiding this comment.
I think this section needs comments because it's super clever and complicated, but someone else maintaining the class won't be able to understand what's going on without a lot of reverse engineering.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #828
Development notes
So far, I copied
ibis.TableDataset, removing code paths for reading database tables, and adding support for file export.Just wanted to put this out there for early feedback, but what else should be done?
TableDatasetFileDataset)FileDatasetto toctree, etc.)Update: Versioning is actually not a trivial subject, because backends don't implement a consistent interface for checking whether a file exists. I plan to do this with PyArrow filesystem, but I will do that in a follow-up PR (to limit complexity added here); this PR handles local versioning.
Checklist
RELEASE.mdfile