chore: Move kedro-catalog JSON schema to kedro-datasets
#952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Schopp <56572144+chrisschopp@users.noreply.github.com>
Signed-off-by: Chris Schopp <56572144+chrisschopp@users.noreply.github.com>
7 tasks
chrisschopp
changed the title
kedro-catalog JSON schema to kedro-datasets
chrisschopp
changed the title
kedro-catalog JSON schema to kedro-datasetskedro-catalog JSON schema to kedro-datasets
Signed-off-by: Chris Schopp <56572144+chrisschopp@users.noreply.github.com>
Signed-off-by: Chris Schopp <56572144+chrisschopp@users.noreply.github.com>
merelcht
reviewed
Dec 10, 2024
There was a problem hiding this comment.
Thanks for the contribution @chrisschopp! This mostly looks good, but now some of the datasets are still part of the core Kedro package, so I don't think those should now still be in the list here.
…nce they remain in Kedro core Signed-off-by: Chris Schopp <56572144+chrisschopp@users.noreply.github.com>
merelcht
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Thanks @chrisschopp ! LGTM 👍
Can you add the change to the release notes as well? Together with your name in the list of contributors: https://github.com/kedro-org/kedro-plugins/blob/main/kedro-datasets/RELEASE.md#community-contributions
Signed-off-by: Chris Schopp <56572144+chrisschopp@users.noreply.github.com>
|
Thanks a lot for the contribution @chrisschopp ! I'll merge this now 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolving 4258
Development notes
Moved
static/jsonschema/fromkedro(there is a corresponding PR there) tokedro-datasets.Checklist
RELEASE.mdfile