Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move kedro-catalog JSON schema to kedro-datasets #4359

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Move kedro-catalog JSON schema to kedro-datasets #4359

wants to merge 6 commits into from

Conversation

chrisschopp
Copy link

@chrisschopp chrisschopp commented Dec 1, 2024 •
edited
Loading

Description

Resolving #4258

Development notes

Moved static/jsonschema/ from kedro to kedro-datasets (there is a corresponding PR there).

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

@chrisschopp
Move kedro-catalog JSON schema to kedro-datasets kedro-org#4258
0a37127 
Signed-off-by: Chris Schopp <56572144+chrisschopp@users.noreply.github.com>
@chrisschopp
Add description of change to RELEASE.md
55261ac 
Signed-off-by: Chris Schopp <56572144+chrisschopp@users.noreply.github.com>
@chrisschopp chrisschopp changed the title Move kedro-catalog JSON schema to kedro-datasets #4258 Move kedro-catalog JSON schema to kedro-datasets Dec 1, 2024
@chrisschopp chrisschopp mentioned this pull request Dec 1, 2024
Merged
5 tasks
chrisschopp
chrisschopp commented Dec 4, 2024
View reviewed changes
docs/source/development/set_up_pycharm.md
@@ -163,10 +163,10 @@ You can enable the Kedro catalog validation schema in your PyCharm IDE to enable

![](../meta/images/pycharm_edit_schema_mapping.png)

Add a new mapping using the "+" button in the top left of the window and select the name you want for it. Enter this URL `https://raw.githubusercontent.com/kedro-org/kedro/develop/static/jsonschema/kedro-catalog-0.19.json` in the "Schema URL" field and select "JSON Schema Version 7" in the "Schema version" field.
Add a new mapping using the "+" button in the top left of the window and select the name you want for it. Enter this URL `https://raw.githubusercontent.com/kedro-org/kedro-plugins/main/kedro-datasets/static/jsonschema/kedro-catalog-0.19.json` in the "Schema URL" field and select "JSON Schema Version 7" in the "Schema version" field.
Copy link
Author

@chrisschopp chrisschopp Dec 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this should point to main.

chrisschopp
chrisschopp commented Dec 4, 2024
View reviewed changes
docs/source/development/set_up_vscode.md
@@ -260,11 +260,11 @@ Enter the following in your `settings.json` file:
```json
{
"yaml.schemas": {
"https://raw.githubusercontent.com/kedro-org/kedro/develop/static/jsonschema/kedro-catalog-0.19.json": "conf/**/*catalog*"
"https://raw.githubusercontent.com/kedro-org/kedro-plugins/main/kedro-datasets/static/jsonschema/kedro-catalog-0.19.json": "conf/**/*catalog*"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this should point to main.

@chrisschopp
Copy link
Author

chrisschopp commented Dec 5, 2024 •
edited
Loading

Edit: not seeing these failing tests on the latest CI run.

### Vale returns three warnings

All are non-issues. Not sure how to mark them as "resolved."

### Failing [e2e-tests (windows-latest, 3.9)
1.

~~Scenario: Execute jupyter setup target~~
~~  Given I have prepared a config file~~
~~  And I have run a non-interactive kedro new with starter "default" ❌ ~~

#### Reason
Error fetching kedro-starters latest release version: 403 Client Error: rate limit exceeded for url: https://api.github.com/repos/kedro-org/kedro-starters/releases/latest

#### Solution
Retry? Is my GitHub rate limit low? I don't think my rate limit would be used in CI...

@chrisschopp
Copy link
Author

chrisschopp commented Dec 10, 2024 •
edited
Loading

Read the docs is failing due to "broken links"

I updated the links to where the JSON files will be once chore: Move kedro-catalog JSON schema to kedro-datasets from kedro-plugins is merged.

Is this the right approach?

@chrisschopp chrisschopp marked this pull request as ready for review December 10, 2024 02:48
@chrisschopp
Copy link
Author

chrisschopp commented Dec 11, 2024 •
edited
Loading

Might need to keep jsonschemas for CachedDataset, MemoryDataset, and LambdaDataset since they remain in Kedro core. See kedro-org/kedro-plugins#952 (review)

@merelcht
Copy link
Member

Read the docs is failing due to "broken links"

I updated the links to where the JSON files will be once chore: Move kedro-catalog JSON schema to kedro-datasets from kedro-plugins is merged.

Is this the right approach?

Yes this is the way to go 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yetudada yetudada Awaiting requested review from yetudada yetudada is a code owner

@astrojuanlu astrojuanlu Awaiting requested review from astrojuanlu astrojuanlu is a code owner

@merelcht merelcht Awaiting requested review from merelcht merelcht is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisschopp @merelcht