-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor disable preview toggle to be only front end #2067
Conversation
Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>
Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>
Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment otherwise looks good :)
Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>
Hi @SajidAlamQB , Thank you for the refactor. Tested this on Gitpod and it works well. I just have 1 question for the flag in the UI. Do we show this flag even on the hosted Kedro-Viz instance ? Like if someone does a For me the flag does make sense in local as the user cannot disable preview on Thank you |
Good spot! As it is, the flag will be shown even if the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @SajidAlamQB
One way we can do this is using the viz_metadata_file that is available in the build/deploy artifacts. At this moment, it has timestamp and version keys. May be adding a json key like |
fair points, I would keep this simple for now the way it is. and wait for user to raise this if it's an issue and then try to fix it. |
Description
Related to: #2042
This ticket is to refactor the preview datasets toggle setting feature to handle logic for previews from FE instead of making BE calls.
This feature enables users to control data previews for all nodes from the settings panel of Kedro-Viz when running kedro viz locally.
After running Kedro-Viz locally, dataset previews for all nodes will be enabled by default. However, users will have the ability to enable or disable this feature from the Kedro-Viz settings panel.
Development notes
We now have a check for the dataset preview toggle in
metadata.js
before rendering the previews.Checklist
RELEASE.md
file