Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding example 16 to the 01_data_catalog.md to show how to load csv f… #1109

Merged
merged 12 commits into from
Jan 31, 2022

Conversation

Isy89
Copy link
Contributor

@Isy89 Isy89 commented Dec 9, 2021

…iles stored in a remote location using the sftp protocol

Description

This PR was created to include an example in the documentation on how to define datasets in the catalog that need to be loaded from a remote location through ssh.

Development notes

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes

…iles stored in a remote location using the sftp protocol
@Isy89 Isy89 requested a review from yetudada as a code owner December 9, 2021 21:58
Copy link
Contributor

@antonymilne antonymilne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for writing this up! I've made a few stylistic modifications to make it a bit more concise and consistent with the rest of our documentation - I would have modified directly but didn't have permission to do so on your branch.

docs/source/05_data/01_data_catalog.md Outdated Show resolved Hide resolved
docs/source/05_data/01_data_catalog.md Outdated Show resolved Hide resolved
docs/source/05_data/01_data_catalog.md Outdated Show resolved Hide resolved
docs/source/05_data/01_data_catalog.md Outdated Show resolved Hide resolved
docs/source/05_data/01_data_catalog.md Outdated Show resolved Hide resolved
docs/source/05_data/01_data_catalog.md Outdated Show resolved Hide resolved
Isy89 and others added 7 commits January 18, 2022 08:15
Co-authored-by: Antony Milne <49395058+AntonyMilneQB@users.noreply.github.com>
Co-authored-by: Antony Milne <49395058+AntonyMilneQB@users.noreply.github.com>
Co-authored-by: Antony Milne <49395058+AntonyMilneQB@users.noreply.github.com>
Co-authored-by: Antony Milne <49395058+AntonyMilneQB@users.noreply.github.com>
Co-authored-by: Antony Milne <49395058+AntonyMilneQB@users.noreply.github.com>
Co-authored-by: Antony Milne <49395058+AntonyMilneQB@users.noreply.github.com>
@lorenabalan lorenabalan merged commit 02598bf into kedro-org:main Jan 31, 2022
lvijnck pushed a commit to lvijnck/kedro that referenced this pull request Apr 7, 2022
kedro-org#1109)

Signed-off-by: Laurens Vijnck <laurens_vijnck@mckinsey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants