Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling in the community-developed plugins docs #1132

Merged
merged 5 commits into from
Jan 7, 2022

Conversation

deepyaman
Copy link
Member

Description

Development notes

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes

@deepyaman
Copy link
Member Author

CircleCI checks aren't triggering, faced this issue several times in the past but now there's no private repo to push to as an alternative. Tried pushing to my fork as well in #1135, but no luck. #1109 (not my PR) seems to face the same issue.

Maybe this can be merged with an override since there's no code changes/it's pretty trivial, but guess this problem will need to be sorted out sooner than later. Think it might be worth checking with CircleCI support, to see if they can diagnose the cause of not running builds in some of these instances?

@antonymilne
Copy link
Contributor

antonymilne commented Jan 4, 2022

This is annoying... I was hoping that my recent rewrite of the CircleCI config would magically fix it. I'll make a ticket to investigate this, thanks for mentioning it again.

@deepyaman
Copy link
Member Author

@MerelTheisenQB triggers the CI with an empty commit, it runs; I try to do the same (to rerun the Windows build that timed out, because I apparently don't have write access to select "Rerun workflow from failed" in CircleCI), and it's stuck again. 🤮

@merelcht
Copy link
Member

merelcht commented Jan 5, 2022

@MerelTheisenQB triggers the CI with an empty commit, it runs; I try to do the same (to rerun the Windows build that timed out, because I apparently don't have write access to select "Rerun workflow from failed" in CircleCI), and it's stuck again. 🤮

This is so frustrating! We'll have to contact CircleCI support.. Let me trigger it again with an empty commit.

Copy link
Contributor

@yetudada yetudada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these changes!

@idanov idanov changed the title Fix inconsistencies in community-developed plugins Fix spelling in the community-developed plugins docs Jan 7, 2022
@merelcht merelcht merged commit e78990c into main Jan 7, 2022
@deepyaman deepyaman deleted the deepyaman-patch-4 branch January 7, 2022 17:14
lorenabalan pushed a commit that referenced this pull request Jan 10, 2022
Signed-off-by: lorenabalan <lorena.balan@quantumblack.com>
lorenabalan pushed a commit that referenced this pull request Jan 10, 2022
Signed-off-by: lorenabalan <lorena.balan@quantumblack.com>
rashidakanchwala pushed a commit that referenced this pull request Jan 10, 2022
Signed-off-by: Rashida Kanchwala <rashida.kanchwala@quantumblack.com>
doytsujin pushed a commit to doytsujin/kedro that referenced this pull request Jan 22, 2022
lvijnck pushed a commit to lvijnck/kedro that referenced this pull request Apr 7, 2022
Signed-off-by: Laurens Vijnck <laurens_vijnck@mckinsey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants