Upper bound pip in CI #1189
Merged
Upper bound pip in CI #1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antony Milne <antony.milne@quantumblack.com>
Signed-off-by: Antony Milne <antony.milne@quantumblack.com>
Signed-off-by: Antony Milne <antony.milne@quantumblack.com>
Signed-off-by: Antony Milne <antony.milne@quantumblack.com>
Signed-off-by: Antony Milne <antony.milne@quantumblack.com>
merelcht
approved these changes
Feb 1, 2022
SajidAlamQB
approved these changes
Feb 1, 2022
idanov
approved these changes
Feb 1, 2022
Galileo-Galilei
pushed a commit
to Galileo-Galilei/kedro
that referenced
this pull request
Feb 19, 2022
Co-authored-by: Merel Theisen <49397448+mereltheisenqb@users.noreply.github.com>
lvijnck
pushed a commit
to lvijnck/kedro
that referenced
this pull request
Apr 7, 2022
Signed-off-by: Laurens Vijnck <laurens_vijnck@mckinsey.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pip 22was released and everything broke. So I put in the boundpip<22, which fixed the pip compile issues but broke the Windows e2e tests 🤦After much digging, I figured out that the warning you get to upgrade pip on the Windows e2e tests for some reason gets interpreted as an error by behave. So in order for these tests to pass we need to use
PIP_DISABLE_PIP_VERSION_CHECK.Everything is now working again apart from (a) Windows 3.6 e2e tests which are still broken with the mysterious Rust error, (b) the forked PRs environment variable issue that we have a ticket for.
Checklist
RELEASE.mdfile