Bump pip-tools version #1215
Merged
Bump pip-tools version #1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antony Milne <antony.milne@quantumblack.com>
Signed-off-by: Antony Milne <antony.milne@quantumblack.com>
Signed-off-by: Antony Milne <antony.milne@quantumblack.com>
merelcht
approved these changes
Feb 7, 2022
lorenabalan
approved these changes
Feb 7, 2022
RELEASE.md
Outdated
| @@ -9,6 +9,7 @@ | |||
| * Added Plotly dataset documentation (`03_tutorial/06_visualise_pipeline.md`). | |||
| * Added the upper limit `pandas<1.4` to maintain compatibility with `xlrd~=1.0`. | |||
| * Bumped the `Pillow` minimum version requirement to 9.0 (Python 3.7+ only) following [CVE-2022-22817](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2022-22817). | |||
| * Upgraded `pip-tools`, which is used by `kedro build-reqs`, to 6.5 (Python 3.7+ only). This `pip-tools` version is compatible with `pip>=21.2`, including the most recent releases of `pip`. | |||
There was a problem hiding this comment.
Can we make a mention that for users still on python 3.6, they need to use older version of pip, i.e. <22? Or did I misunderstand this?
There was a problem hiding this comment.
Python 3.6 users will be on pip<22 anyway, but I've added a note to be explicit here (since I also had to think about this for a while to figure out what was going on...😀 )
lorenabalan
reviewed
Feb 7, 2022
antonymilne
commented
Feb 7, 2022
Galileo-Galilei
pushed a commit
to Galileo-Galilei/kedro
that referenced
this pull request
Feb 19, 2022
lvijnck
pushed a commit
to lvijnck/kedro
that referenced
this pull request
Apr 7, 2022
Signed-off-by: Laurens Vijnck <laurens_vijnck@mckinsey.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1208. In short,
pip-tools==6.4.0is not compatible with the recently releasedpip>=22.pip-toolshave now released a fix version6.5.0which does work withpip>=22, but it's only compatible with Python 3.7+.I've also reversed the changes to CI made in #1189 so that the pip requirement is now open-ended again. I actually think this is a good system because if pip releases a new version that breaks our CI it gives us an immediate warning that other stuff will likely break also.
Checklist
RELEASE.mdfile