Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant hint when already used #3439

Merged
merged 12 commits into from
Dec 20, 2023

Conversation

AhdraMeraliQB
Copy link
Contributor

Description

Resolves #3365
Found that "You have selected no project tools" wasn't always shown when appropriate, included that fix in this PR

Development notes

Instead of testing the negative case, the tests test that the hint is shown where relevant. Manual testing reveals the hint is no longer shown where already used. Unsure on best practice here - happy to include a unit test for the negative case as well.

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

Ahdra Merali added 6 commits December 18, 2023 16:43
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
@merelcht
Copy link
Member

Instead of testing the negative case, the tests test that the hint is shown where relevant. Manual testing reveals the hint is no longer shown where already used. Unsure on best practice here - happy to include a unit test for the negative case as well.

IMO it would be good to also add the negative case, see e.g. https://github.com/kedro-org/kedro/pull/3424/files

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Copy link
Contributor

@DimedS DimedS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @AhdraMeraliQB , great job!

Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding the extra tests, this makes it clear when the message is expected and when it isn't 👍

@AhdraMeraliQB AhdraMeraliQB merged commit 52a3d11 into main Dec 20, 2023
30 checks passed
@AhdraMeraliQB AhdraMeraliQB deleted the fix/remove-redundant-message branch December 20, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove redundant hint if user is already using the hint
5 participants