Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Database filename case shouldn't be changed on save (after opening it from the command line) #7139

Closed
tomasz1986 opened this issue Nov 17, 2021 · 0 comments · Fixed by #7214
Closed

Database filename case shouldn't be changed on save (after opening it from the command line) #7139

tomasz1986 opened this issue Nov 17, 2021 · 0 comments · Fixed by #7214
Labels
bug
Milestone
v2.7.2

Comments

@tomasz1986
Copy link

Overview

This is weird issue, but I think it could potentially be quite nasty, e.g. when syncing the database file between case sensitive and insensitive systems. What happens is that if you open a database file from the command line, KeePassXC will remember the filename case as it was input in the command. Then, when you save changes to the database, the original case will be overwritten with the other one. I don't think this is intended, is it?

Steps to Reproduce

  1. Create a new database called TEST.kdbx.
  2. Open the newly created database using the command line, but using a different case, e.g. keepassxc test.kdbx. Obviously, this will only work in case insensitive systems like Windows.
  3. Make a change to the database, then save it.
  4. The database filename has now been renamed from TEST.kdbx to test.kdbx.

Expected Behavior

The database file case should remain as it was in the original file, i.e. it shouldn't follow the one used in the command line when starting KeePassXC.

Actual Behavior

The database file case changes to the one used in the command line argument.

Context

KeePassXC - 2.6.6
Revision: 9c108b9

Operating System: Windows 10
Desktop Env: N/A
Windowing System: N/A
@tomasz1986 tomasz1986 added the bug label Nov 17, 2021
@mckeema mckeema mentioned this issue Dec 9, 2021
Merged
@droidmonkey droidmonkey added this to the v2.7.1 milestone Mar 21, 2022
@phoerious phoerious modified the milestones: v2.7.1, v2.7.2 Apr 12, 2022
droidmonkey pushed a commit to mckeema/keepassxc that referenced this issue Sep 10, 2022
@mckeema @droidmonkey
Set correct case for database file path on Windows
b121269 
* Fix keepassxreboot#7139 - when opening database files from the command line, ensure the correct case is fed to the program to prevent case changes during saves.
* Cleanup old code (checking for .json extension) from when KeePassXC app could act as a proxy.
droidmonkey pushed a commit that referenced this issue Sep 10, 2022
@mckeema @droidmonkey
Set correct case for database file path on Windows
dd15db7 
* Fix #7139 - when opening database files from the command line, ensure the correct case is fed to the program to prevent case changes during saves.
* Cleanup old code (checking for .json extension) from when KeePassXC app could act as a proxy.
pull bot pushed a commit to annihilatorrrr/keepassxc that referenced this issue Sep 10, 2022
@mckeema @pull
Set correct case for database file path on Windows
f4f1f4b 
* Fix keepassxreboot#7139 - when opening database files from the command line, ensure the correct case is fed to the program to prevent case changes during saves.
* Cleanup old code (checking for .json extension) from when KeePassXC app could act as a proxy.
pull bot pushed a commit to tigerwill90/keepassxc that referenced this issue Sep 10, 2022
@mckeema @pull
Set correct case for database file path on Windows
f16cb5b 
* Fix keepassxreboot#7139 - when opening database files from the command line, ensure the correct case is fed to the program to prevent case changes during saves.
* Cleanup old code (checking for .json extension) from when KeePassXC app could act as a proxy.
droidmonkey pushed a commit that referenced this issue Sep 11, 2022
@mckeema @droidmonkey
Set correct case for database file path on Windows
3098bb1 
* Fix #7139 - when opening database files from the command line, ensure the correct case is fed to the program to prevent case changes during saves.
* Cleanup old code (checking for .json extension) from when KeePassXC app could act as a proxy.
droidmonkey pushed a commit that referenced this issue Sep 22, 2022
@mckeema @droidmonkey
Set correct case for database file path on Windows
31924fc 
* Fix #7139 - when opening database files from the command line, ensure the correct case is fed to the program to prevent case changes during saves.
* Cleanup old code (checking for .json extension) from when KeePassXC app could act as a proxy.
@jNullj jNullj mentioned this issue Nov 9, 2022
Closed
jNullj added a commit to jNullj/keepassxc-fetures-n-fixes that referenced this issue Nov 10, 2022
@jNullj
Fixed issue where filenames could change
3326ff7 
Solve filename changes as shown in issue keepassxreboot#7139.
If filename input is not the same capitalization file extention was added to file name when saved.
This change fixes it.

Fixes keepassxreboot#8751
@jNullj jNullj mentioned this issue Nov 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v2.7.2
Development

Successfully merging a pull request may close this issue.

Set correct case for DB file path on open (fix for #7139) mckeema/keepassxc
3 participants
@phoerious @droidmonkey @tomasz1986