Fix/8751 unicode filename fix for windows #8782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FindFirstFile doesn't support unicode in file names. Switch to FindFirstFileEx to allow unicode in db file name. Fixes keepassxreboot#8751
Use FindFirstFileW for explicit unicode support. Use curret types to avoid casting issues. Fixes keepassxreboot#8751
Solve filename changes as shown in issue keepassxreboot#7139. If filename input is not the same capitalization file extention was added to file name when saved. This change fixes it. Fixes keepassxreboot#8751
Codecov ReportBase: 64.43% // Head: 64.42% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #8782 +/- ##
===========================================
- Coverage 64.43% 64.42% -0.01%
===========================================
Files 341 341
Lines 44247 44247
===========================================
- Hits 28507 28504 -3
- Misses 15740 15743 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
phoerious
reviewed
Nov 10, 2022
phoerious
approved these changes
Nov 10, 2022
Change to method obtaining absolute file path from toStdWString to utf16. This avoids internal conversation in QString as it is stored as utf16 ushort. Fixes keepassxreboot#8751
droidmonkey
approved these changes
Nov 10, 2022
phoerious
approved these changes
Nov 11, 2022
droidmonkey
pushed a commit
that referenced
this pull request
Feb 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8751
Screenshots
explorer_2022-11-10_18-49-00.mp4
Testing strategy
Compiled and run the application on windows.
Attempted to reproduce both #8751 and #7139 and tested both are solved.
It could be neat if i could run automated testing on github without playing with my own environment...
edit: i see you got some actions running on pull, forget about the line above.
Type of change