fix: Avoid launch template creation loop when switching from launch c…

…onfig and failing (#346) * bug fix for launchTemplate loop reconcile Signed-off-by: sbadla1 <sahil_badla@intuit.com> * bug fix for launchTemplate loop reconcile Signed-off-by: sbadla1 <sahil_badla@intuit.com> * bug fix for launchTemplate loop reconcile Signed-off-by: sbadla1 <sahil_badla@intuit.com>
keikoproj · Feb 11, 2022 · 3099305 · 3099305
1 parent bda2adc
commit 3099305
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/controllers/provisioners/eks/cloud.go b/controllers/provisioners/eks/cloud.go
@@ -226,7 +226,8 @@ func (ctx *EksInstanceGroupContext) CloudDiscovery() error {
 	if spec.IsLaunchConfiguration() {
 
 		state.ScalingConfiguration, err = scaling.NewLaunchConfiguration(instanceGroup.NamespacedName(), ctx.AwsWorker, &scaling.DiscoverConfigurationInput{
-			ScalingGroup: targetScalingGroup,
+			ScalingGroup:     targetScalingGroup,
+			TargetConfigName: state.ScalingConfiguration.Name(),
 		})
 		if err != nil {
 			return errors.Wrap(err, "failed to discover launch configurations")
@@ -238,7 +239,8 @@ func (ctx *EksInstanceGroupContext) CloudDiscovery() error {
 
 	if spec.IsLaunchTemplate() {
 		state.ScalingConfiguration, err = scaling.NewLaunchTemplate(instanceGroup.NamespacedName(), ctx.AwsWorker, &scaling.DiscoverConfigurationInput{
-			ScalingGroup: targetScalingGroup,
+			ScalingGroup:     targetScalingGroup,
+			TargetConfigName: state.ScalingConfiguration.Name(),
 		})
 		if err != nil {
 			return errors.Wrap(err, "failed to discover launch templates")