fix: Avoid launch template creation loop when switching from launch config and failing #346
Conversation
Signed-off-by: sbadla1 <sahil_badla@intuit.com>
| @@ -238,7 +238,7 @@ func (ctx *EksInstanceGroupContext) CloudDiscovery() error { | |||
|
|
|||
| if spec.IsLaunchTemplate() { | |||
| state.ScalingConfiguration, err = scaling.NewLaunchTemplate(instanceGroup.NamespacedName(), ctx.AwsWorker, &scaling.DiscoverConfigurationInput{ | |||
| ScalingGroup: targetScalingGroup, | |||
There was a problem hiding this comment.
I think the current implementation discovers the active launch template by the scaling group name, can you look inside NewLaunchTemplate and see if there is a reason this is not happening?
There was a problem hiding this comment.
Looks like we are not setting TargetConfigName inside Discover:
https://github.com/sahilbadla/instance-manager/blob/58ad1a253a80900c2a1047c5809ca1d94e300d00/controllers/provisioners/eks/scaling/launchtemplate.go#L58
Can you try that instead?
That way we don't rely on status field, but rather discover the active Launch Template name each time from the scaling group name.
Signed-off-by: sbadla1 <sahil_badla@intuit.com>
Signed-off-by: sbadla1 <sahil_badla@intuit.com>
eytan-avisror
changed the title
Codecov Report
@@ Coverage Diff @@
## master #346 +/- ##
==========================================
+ Coverage 51.15% 51.17% +0.02%
==========================================
Files 33 33
Lines 4514 4516 +2
==========================================
+ Hits 2309 2311 +2
Misses 2063 2063
Partials 142 142
Continue to review full report at Codecov.
|
Signed-off-by: sbadla1 sahil_badla@intuit.com
closes #340
Endless LaunchTemplate creation loop happens when swtiching from launchConfig to LaunchTemplate.
Fixed the launchTemplate discovery logic to pass latest template config instead of ASG config(that still has launchConfig)