-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make launchtemplates as a default scaling group configuration, instead of launchconfigurations. #385
Conversation
Codecov Report
@@ Coverage Diff @@
## master #385 +/- ##
==========================================
+ Coverage 51.37% 51.43% +0.06%
==========================================
Files 33 33
Lines 4557 4571 +14
==========================================
+ Hits 2341 2351 +10
- Misses 2069 2075 +6
+ Partials 147 145 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Update the release notes with this change and clearly point out that we need to add additional permissions for Launch templates if missing so that the controller can make a seamless transition from launch configuration to Launch templates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…#387) * feat: support overriding default scaling configuration (#385) * make launchtemplates default Signed-off-by: sbadiger <shreyas_badiger@intuit.com> * remove additional new lint Signed-off-by: sbadiger <shreyas_badiger@intuit.com> * indentation Signed-off-by: sbadiger <shreyas_badiger@intuit.com> * update default config type Signed-off-by: sbadiger <shreyas_badiger@intuit.com> * update spec Signed-off-by: sbadiger <shreyas_badiger@intuit.com> * refactor the default scaling config code Signed-off-by: sbadiger <shreyas_badiger@intuit.com> * add unit tests Signed-off-by: sbadiger <shreyas_badiger@intuit.com> * fix unit tests Signed-off-by: sbadiger <shreyas_badiger@intuit.com> * indent Signed-off-by: sbadiger <shreyas_badiger@intuit.com> * update defaultScalingConfiguration flag description Signed-off-by: sbadiger <shreyas_badiger@intuit.com> --------- Signed-off-by: sbadiger <shreyas_badiger@intuit.com> * set LaunchTemplate as default value for default-scaling-configuration Signed-off-by: sbadiger <shreyas_badiger@intuit.com> * validate scaling-config-override flag Signed-off-by: sbadiger <shreyas_badiger@intuit.com> * chore(deps): Bump gopkg.in/yaml.v3 (#386) Bumps gopkg.in/yaml.v3 from 3.0.0-20210107192922-496545a6307b to 3.0.0. --- updated-dependencies: - dependency-name: gopkg.in/yaml.v3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Todd Ekenstam <3845995+tekenstam@users.noreply.github.com> Signed-off-by: sbadiger <shreyas_badiger@intuit.com> --------- Signed-off-by: sbadiger <shreyas_badiger@intuit.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Todd Ekenstam <3845995+tekenstam@users.noreply.github.com>
The configurations for the AutoscalingGroups could be specified in either a launchConfiguration or a launchTemplate. launchtemplates has several benefits over launchconfigurations:
aws blog-post
Additionally, launchconfigurations is being slowly phased out.