Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make launchtemplates as a default scaling group configuration, instead of launchconfigurations. #385

Merged
merged 10 commits into from
Aug 31, 2023

Conversation

shreyas-badiger
Copy link
Contributor

@shreyas-badiger shreyas-badiger commented Aug 22, 2023

The configurations for the AutoscalingGroups could be specified in either a launchConfiguration or a launchTemplate. launchtemplates has several benefits over launchconfigurations:

  • ability to have increased number of scaling groups in a cluster.
  • support for mixed instance type in a ASG.
  • support for newer instance type in ASG.

aws blog-post

AWS released launch templates, the successor of launch configurations, as a way to streamline and simplify the launch process for Auto Scaling, Spot Fleet, Amazon EC2 Spot Instances, and On-Demand Instances. Launch templates define the steps required to create an instance, by capturing instance parameters in a resource that can be used across multiple services. Launch configurations have continued to live alongside launch templates but haven’t benefitted from all of the features we’ve added to launch templates.

Today, AWS is recommending that customers using launch configurations migrate to launch templates. We will continue to support and maintain launch configurations, but we will not be adding any new features to them. We will focus on adding new EC2 features to launch templates only. You can continue using launch configurations, and AWS is committed to supporting applications you have already built using them, but in order for you to take advantage of our most recent and upcoming releases, a migration to launch templates is recommended. Additionally, we plan to no longer support new instance types with launch configurations by the end of 2022. Our goal is to have all customers moved over to launch templates by then.

Additionally, launchconfigurations is being slowly phased out.
Screenshot 2023-08-22 at 3 18 17 PM

@shreyas-badiger shreyas-badiger requested review from a team as code owners August 22, 2023 22:22
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #385 (d823aaa) into master (7c2bf62) will increase coverage by 0.06%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##           master     #385      +/-   ##
==========================================
+ Coverage   51.37%   51.43%   +0.06%     
==========================================
  Files          33       33              
  Lines        4557     4571      +14     
==========================================
+ Hits         2341     2351      +10     
- Misses       2069     2075       +6     
+ Partials      147      145       -2     
Files Changed Coverage Δ
api/v1alpha1/zz_generated.deepcopy.go 0.00% <0.00%> (ø)
api/v1alpha1/instancegroup_types.go 21.28% <66.66%> (+2.59%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Copy link

@kevdowney kevdowney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eytan-avisror eytan-avisror merged commit d1e5113 into keikoproj:master Aug 31, 2023
4 of 5 checks passed
@vgunapati
Copy link
Contributor

vgunapati commented Aug 31, 2023

Update the release notes with this change and clearly point out that we need to add additional permissions for Launch templates if missing so that the controller can make a seamless transition from launch configuration to Launch templates

Copy link
Member

@tekenstam tekenstam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shreyas-badiger added a commit that referenced this pull request Sep 19, 2023
…#387)

* feat: support overriding default scaling configuration (#385)

* make launchtemplates default

Signed-off-by: sbadiger <shreyas_badiger@intuit.com>

* remove additional new lint

Signed-off-by: sbadiger <shreyas_badiger@intuit.com>

* indentation

Signed-off-by: sbadiger <shreyas_badiger@intuit.com>

* update default config type

Signed-off-by: sbadiger <shreyas_badiger@intuit.com>

* update spec

Signed-off-by: sbadiger <shreyas_badiger@intuit.com>

* refactor the default scaling config code

Signed-off-by: sbadiger <shreyas_badiger@intuit.com>

* add unit tests

Signed-off-by: sbadiger <shreyas_badiger@intuit.com>

* fix unit tests

Signed-off-by: sbadiger <shreyas_badiger@intuit.com>

* indent

Signed-off-by: sbadiger <shreyas_badiger@intuit.com>

* update defaultScalingConfiguration flag description

Signed-off-by: sbadiger <shreyas_badiger@intuit.com>

---------

Signed-off-by: sbadiger <shreyas_badiger@intuit.com>

* set LaunchTemplate as default value for default-scaling-configuration

Signed-off-by: sbadiger <shreyas_badiger@intuit.com>

* validate scaling-config-override flag

Signed-off-by: sbadiger <shreyas_badiger@intuit.com>

* chore(deps): Bump gopkg.in/yaml.v3 (#386)

Bumps gopkg.in/yaml.v3 from 3.0.0-20210107192922-496545a6307b to 3.0.0.

---
updated-dependencies:
- dependency-name: gopkg.in/yaml.v3
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Todd Ekenstam <3845995+tekenstam@users.noreply.github.com>
Signed-off-by: sbadiger <shreyas_badiger@intuit.com>

---------

Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Todd Ekenstam <3845995+tekenstam@users.noreply.github.com>
@shreyas-badiger shreyas-badiger mentioned this pull request Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants