set LaunchTemplate as default value for default-scaling-configuration #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #387 +/- ##
==========================================
+ Coverage 51.43% 51.45% +0.02%
==========================================
Files 33 33
Lines 4571 4573 +2
==========================================
+ Hits 2351 2353 +2
Misses 2075 2075
Partials 145 145
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
nvandanapu
approved these changes
Sep 14, 2023
vgunapati
approved these changes
Sep 14, 2023
* make launchtemplates default Signed-off-by: sbadiger <shreyas_badiger@intuit.com> * remove additional new lint Signed-off-by: sbadiger <shreyas_badiger@intuit.com> * indentation Signed-off-by: sbadiger <shreyas_badiger@intuit.com> * update default config type Signed-off-by: sbadiger <shreyas_badiger@intuit.com> * update spec Signed-off-by: sbadiger <shreyas_badiger@intuit.com> * refactor the default scaling config code Signed-off-by: sbadiger <shreyas_badiger@intuit.com> * add unit tests Signed-off-by: sbadiger <shreyas_badiger@intuit.com> * fix unit tests Signed-off-by: sbadiger <shreyas_badiger@intuit.com> * indent Signed-off-by: sbadiger <shreyas_badiger@intuit.com> * update defaultScalingConfiguration flag description Signed-off-by: sbadiger <shreyas_badiger@intuit.com> --------- Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Bumps gopkg.in/yaml.v3 from 3.0.0-20210107192922-496545a6307b to 3.0.0. --- updated-dependencies: - dependency-name: gopkg.in/yaml.v3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Todd Ekenstam <3845995+tekenstam@users.noreply.github.com> Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #385 changed the ASG default from LaunchConfigurations to LaunchTemplates.
There was a small mistake, where the
default-scaling-configurationflag name was accidentally left empty.This PR will fix the naming and also provide a default value.