Skip to content
This repository has been archived by the owner on Jul 9, 2024. It is now read-only.

Master branch broken because of incorrect use of variable #28

Closed
shrinandj opened this issue Mar 26, 2019 · 0 comments
Closed

Master branch broken because of incorrect use of variable #28

shrinandj opened this issue Mar 26, 2019 · 0 comments

Comments

@shrinandj
Copy link
Collaborator

Switching to on-demand instances from spot-instances is currently broken because of the following:

2019-03-26T05:38:29 ERROR aws_minion_manager MainThread: Failed while checking instances in ASG: global name 'spot_price' is not defined
Traceback (most recent call last):
  File "/src/cloud_provider/aws/aws_minion_manager.py", line 593, in minion_manager_work
    self.update_scaling_group(asg_meta, new_bid_info)
  File "/src/cloud_provider/aws/aws_minion_manager.py", line 330, in update_scaling_group
    self.create_lc_on_demand(new_lc_name, launch_config)
  File "/usr/local/lib/python2.7/site-packages/retrying.py", line 49, in wrapped_f
    return Retrying(*dargs, **dkw).call(f, *args, **kw)
  File "/usr/local/lib/python2.7/site-packages/retrying.py", line 212, in call
    raise attempt.get()
  File "/usr/local/lib/python2.7/site-packages/retrying.py", line 247, in get
    six.reraise(self.value[0], self.value[1], self.value[2])
  File "/usr/local/lib/python2.7/site-packages/retrying.py", line 200, in call
    attempt = Attempt(fn(*args, **kwargs), attempt_number, False)
  File "/src/cloud_provider/aws/aws_minion_manager.py", line 270, in create_lc_on_demand
    SpotPrice=spot_price,
NameError: global name 'spot_price' is not defined
shrinandj added a commit to shrinandj/minion-manager that referenced this issue Mar 27, 2019
Testing Done:

- Unit tests pass.

Closes keikoproj#28.
shrinandj added a commit that referenced this issue Mar 27, 2019
Testing Done:

- Unit tests pass.

Closes #28.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant