Skip to content
This repository has been archived by the owner on Jul 9, 2024. It is now read-only.

minion manager should support events only mode #50

Closed
vgunapati opened this issue Aug 30, 2019 · 3 comments · Fixed by #60
Closed

minion manager should support events only mode #50

vgunapati opened this issue Aug 30, 2019 · 3 comments · Fixed by #60
Assignees

Comments

@vgunapati
Copy link
Collaborator

vgunapati commented Aug 30, 2019

Minion Manager should support Kubernetes events only mode

  • Published structured JSON with IG-name, Bid price, and aws-region, etc
  • Minion Manager will only publish recommendation and will not take any action
@commandknight
Copy link

How would "Events Only Mode" be enabled or configured?

@shrinandj
Copy link
Collaborator

Currently, minion-manager makes changes to the ASG/launch-configuration based on the bid-price, spot-instance price, running instances, region and instance-type. Whenever minion-manager makes changes, it adds log messages accordingly. For the purpose of this Github issue, the following are the requirements

Requirements

  • Minion-manager should create Kubernetes events everytime it factors in the on-demand price, spot-instance price and comes up with a recommendation. It is possible that no changes are made to existing setup (i.e. instances continue to run as they are). But the recommendation should still generate a Kubernetes event.

  • The actual content of the event should be structured json: {"apiVersion":"v1alpha1","spotPrice":"0.0067", "useSpot": true}. See Feature: Recommendation Reconciler instance-manager#35 (comment) for more details.

  • The default behavior of minion-manager should be to generate the above event AND make the changes to ASGs as it currently does.

  • In addition, minion-manager should have a new cli option called --events-only.

  • If this option is enabled, minion-manager should only generate the K8s events and not actually make the changes to the ASG/launch-config.

@eytan-avisror
Copy link

Can we prioritize this? @shrinandj not sure if anyone already working on it.. I can probably try doing this..

@shrinandj shrinandj self-assigned this Dec 21, 2019
shrinandj added a commit to shrinandj/minion-manager that referenced this issue Dec 21, 2019
Testing Done:

- Verified that events get logged at periodic intervals
- Verified that data in the event is correct
- Verified that existing unit tests pass

Refs keikoproj#50
shrinandj added a commit to shrinandj/minion-manager that referenced this issue Dec 21, 2019
Testing Done:

- Verified that events get logged at periodic intervals
- Verified that data in the event is correct
- Verified that existing unit tests pass

Refs keikoproj#50
shrinandj added a commit to shrinandj/minion-manager that referenced this issue Dec 21, 2019
Testing Done:

- Verified that events get logged at periodic intervals
- Verified that data in the event is correct
- Verified that existing unit tests pass

Refs keikoproj#50
vgunapati pushed a commit that referenced this issue Dec 29, 2019
Testing Done:

- Verified that events get logged at periodic intervals
- Verified that data in the event is correct
- Verified that existing unit tests pass

Refs #50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants