feat(cli): provide descriptive server start error #4171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuri1969
force-pushed
the
server-cmd-validation
branch
from
d2f8bca
to
11b93a4
Compare
|
@yuri1969 thanks for your contribution. I may not have been too precise in the issue but the idea what to say wich property is missing and log a line with the part of the configuration guide linked to this precise property. Could you make the changes? |
* The validation is based just on 3 basic Kestra properties. * Provided a description and link to the docs in the error. * The `server local` nor any other non-`server` commands were affected. * Added a crude test.
yuri1969
force-pushed
the
server-cmd-validation
branch
from
11b93a4
to
349d5ce
Compare
|
@loicmathieu The PR now lists each missing property along with link to the related section of Configuration Setup separately. Is there any better fit in the docs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are being made and why?
server localnor any other non-servercommands were affected.closes #4155