Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): descriptive server start error via bean #4367

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

yuri1969
Copy link
Contributor

What changes are being made and why?

This is a new iteration of #4171 attempting to resolve #4155 properly. The MICRONAUT_ENVIRONMENTS env variable is no longer ignored.

The validation is performed via a @Context-scoped bean. I'm no Micronaut DI expert 😐

Validated the environment properties via a dedicated bean.
Copy link
Member

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a @Context bean is indead the way to go ;)

@loicmathieu loicmathieu merged commit cc0c44b into kestra-io:develop Jul 22, 2024
6 of 7 checks passed
@yuri1969 yuri1969 deleted the server-cmd-validation2 branch July 22, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Provides a better error message when Kestra cannot be started due to misconfiguration
2 participants