V1.0 breaking changes #261
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmadlener
force-pushed
the
v1.0-breaking-changes
branch
2 times, most recently
from
185bd20
to
8a534b8
Compare
tmadlener
commented
Feb 13, 2024
Avoids clash with type-name
* Make momentum use doubles instead of floats * Fix python unittests * Add a constructor from Vector3f for Vector3d This direction should not suffer from narrowing
tmadlener
force-pushed
the
v1.0-breaking-changes
branch
from
2af61f3
to
b7c29f4
Compare
tmadlener
force-pushed
the
v1.0-breaking-changes
branch
from
b7c29f4
to
0e97824
Compare
|
Should we have a branch like this one in every affected repo? Otherwise it's impossible to test it, and should have the same name obviously |
|
At this point this PR is not useful since all but one of the PRs have been merged and this one isn't up to date |
This was not quite the descriptive PR title that I thought it was, and it is turning out to be quite annoying to deal with for us due to the removal of the vector member of raw hits in TrackerHit. Same for ACTS, which is relying on the raw hits. Edit: ACTS abuses this somewhat, but we are using this in the intended way: to refer to raw hits. |
|
This is what causes us to move more datatypes into EDM4eic instead of using EDM4hep 🤷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR that is not intended to be merged! It collects all the upcoming breaking changes in one place for easier testing of the final result after all of them have been merged. It currently contains the changes from:
More changes are still to come and will show up here as soon as they are ready. Please use the dedicated PRs for mentioning specific issues that are caused / raised by them.
@wdconinc this is a sort of WIP of the branch we discussed at the last Key4hep meeting.
Also tagging @BrieucF @kjvbrt and @mirguest as these will almost certainly also affect you.