fix(developer): work around devDependencies bug in npm #6074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates to npm/cli#2921 This issue arises after moving from npm 6.x to 7.x or later. As the build agents are still on 6.x, we have not yet seen this issue there. As part of the release build for Keyman Developer, we bundle up some files and do some work in a temp folder to prepare folders for release. Even though we are only working with `dependencies` (e.g. using `npm install --production`), packages under `devDependencies` are still wrongly being checked by NPM. As we have two modules present in `devDependencies` that are only available when in the repo path, we need to remove them before attempting to continue. Yuck! ref: npm/cli#3975 (comment) ref: npm/cli#2921
User Test ResultsTest specification and instructions User tests are not required Test Artifacts |
This made the string processing needed much simpler than when it was embedded within the Makefile, where horrible escaping proved necessary.
rc-swag
reviewed
Dec 21, 2021
|
Changes in this pull request will be available for download in Keyman version 15.0.172-alpha |
mcdurdin
added a commit
that referenced
this pull request
Jan 10, 2022
Fixes a build failure after #6074 was merged. The final grep statement in the line cat package.json | grep -v "@keymanapp/models-templates" | grep -v "@keymanapp/models-wordbreakers" > package.json would fail to find anything to exclude, and return an error value, so the script would fail, as we use `set -e`. We didn't care that it didn't find anything to exclude... so we will ignore the return value.
mcdurdin
added a commit
that referenced
this pull request
Jan 16, 2022
mcdurdin
added a commit
that referenced
this pull request
Jan 17, 2022
…success fix(developer): repatch #6074
mcdurdin
added a commit
that referenced
this pull request
Jan 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to npm/cli#2921
This issue arises after moving from npm 6.x to 7.x or later. As the build agents are still on 6.x, we have not yet seen this issue there.
As part of the release build for Keyman Developer, we bundle up some files and do some work in a temp folder to prepare folders for release. Even though we are only working with
dependencies(e.g. usingnpm install --production), packages underdevDependenciesare still wrongly being checked by NPM. As we have two modules present indevDependenciesthat are only available when in the repo path, we need to remove them before attempting to continue. Yuck!ref: npm/cli#3975 (comment)
ref: npm/cli#2921
@keymanapp-test-bot skip