Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(developer): work around devDependencies bug in npm #6074

Merged
merged 6 commits into from
Dec 22, 2021

Commits on Dec 21, 2021

  1. fix(developer): work around devDependencies bug in npm

    Relates to npm/cli#2921
    
    This issue arises after moving from npm 6.x to 7.x or later. As the
    build agents are still on 6.x, we have not yet seen this issue there.
    
    As part of the release build for Keyman Developer, we bundle up some
    files and do some work in a temp folder to prepare folders for release.
    Even though we are only working with `dependencies` (e.g. using `npm
    install --production`), packages under `devDependencies` are still
    wrongly being checked by NPM. As we have two modules present in
    `devDependencies` that are only available when in the repo path, we need
    to remove them before attempting to continue. Yuck!
    
    ref: npm/cli#3975 (comment)
    ref: npm/cli#2921
    mcdurdin committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    a5575e0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    23a29e2 View commit details
    Browse the repository at this point in the history
  3. chore(developer): refactor model compiler bundling into bash script

    This made the string processing needed much simpler than
    when it was embedded within the Makefile, where horrible
    escaping proved necessary.
    mcdurdin committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    5fccc11 View commit details
    Browse the repository at this point in the history
  4. chore: fix bundle.sh call

    mcdurdin committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    87f0d80 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2021

  1. chore: temp set -x

    mcdurdin committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    2e13e7f View commit details
    Browse the repository at this point in the history
  2. fix(developer): bundle.sh rm

    mcdurdin committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    984d429 View commit details
    Browse the repository at this point in the history