breakout envoyinit #10499
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,23 +10,26 @@ | |
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| // TODO: commenting out go generate for now, it can't exist until we figure out how to get the types from within | ||
|
There was a problem hiding this comment. i tried doing this locally and it seemed to work.. what are you seeing? There was a problem hiding this comment. @yuval-k and I spent some time on this and was seeing the same behavior. I think we'll need to move forward with this hack until we properly fix envoyinit |
||
| // the correct version of go-control-plane; see: https://github.com/kgateway-dev/kgateway/issues/10491 | ||
|
|
||
| //xo:generate sh -c "echo '// Licensed under the Apache License, Version 2.0 (the \"License\");' > filter_types.gen.go" | ||
| //xo:generate sh -c "echo '// you may not use this file except in compliance with the License.' >> filter_types.gen.go" | ||
| //xo:generate sh -c "echo '// You may obtain a copy of the License at' >> filter_types.gen.go" | ||
| //xo:generate sh -c "echo '//' >> filter_types.gen.go" | ||
| //xo:generate sh -c "echo '// http://www.apache.org/licenses/LICENSE-2.0' >> filter_types.gen.go" | ||
| //xo:generate sh -c "echo '//' >> filter_types.gen.go" | ||
| //xo:generate sh -c "echo '// Unless required by applicable law or agreed to in writing, software' >> filter_types.gen.go" | ||
| //xo:generate sh -c "echo '// distributed under the License is distributed on an \"AS IS\" BASIS,' >> filter_types.gen.go" | ||
| //xo:generate sh -c "echo '// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.' >> filter_types.gen.go" | ||
| //xo:generate sh -c "echo '// See the License for the specific language governing permissions and' >> filter_types.gen.go" | ||
| //xo:generate sh -c "echo '// limitations under the License.\n' >> filter_types.gen.go" | ||
| //xo:generate sh -c "echo '// GENERATED FILE -- DO NOT EDIT\n' >> filter_types.gen.go" | ||
| //xo:generate sh -c "echo 'package filter_types\n\nimport (' >> filter_types.gen.go" | ||
| //xo:generate sh -c "go list github.com/envoyproxy/go-control-plane/... | grep 'v[3-9]' | xargs -n1 -I{} echo '\t_ \"{}\"' >> filter_types.gen.go" | ||
| //xo:generate sh -c "echo '\n\t// gloo filter types' >> filter_types.gen.go" | ||
| //xo:generate sh -c "go list github.com/solo-io/envoy-gloo/go/... | xargs -n1 -I{} echo '\t_ \"{}\"' >> filter_types.gen.go" | ||
| //xo:generate sh -c "echo ')' >> filter_types.gen.go" | ||
|
|
||
| package filter_types | ||
|
|
||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this still need to be exported? I don't see any other references in the diff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leftover from copy/paste; fixed