breakout envoyinit #10499
breakout envoyinit #10499
Conversation
lgadban
force-pushed
the
law/breakout-envoyinit
branch
from
30b0439 to
4f37ebb
Compare
pkg/utils/defaults/defaults.go
Outdated
| const GlooSystem = "gloo-system" | ||
| const GlooFed = "gloo-system" |
There was a problem hiding this comment.
where are these used? remove?
There was a problem hiding this comment.
leftover cleanup, fixed
| //go:generate sh -c "echo '\n\t// gloo filter types' >> filter_types.gen.go" | ||
| //go:generate sh -c "go list github.com/solo-io/gloo/projects/gloo/pkg/api/external/envoy/... | xargs -n1 -I{} echo '\t_ \"{}\"' >> filter_types.gen.go" | ||
| //go:generate sh -c "echo ')' >> filter_types.gen.go" | ||
| // TODO: commenting out go generate for now, it can't exist until we figure out how to get the types from within |
There was a problem hiding this comment.
i tried doing this locally and it seemed to work.. what are you seeing?
There was a problem hiding this comment.
@yuval-k and I spent some time on this and was seeing the same behavior.
I think we'll need to move forward with this hack until we properly fix envoyinit
|
@lgadban Do we still need to pin the gloo envoy image in the deployment chart with these changes, or is this a precursor to removing gloo and eventually removing that hack that deploys a hardcoded gloo envoy image? |
@timflannagan This is correct, it's the precursor to removing gloo; for now we'll keep the envoy image hardcoded |
| @@ -32,6 +31,8 @@ const ( | |||
| ServerInfoPath = "server_info" | |||
| ) | |||
|
|
|||
| var EnvoyAdminPort uint32 = 19000 | |||
There was a problem hiding this comment.
Does this still need to be exported? I don't see any other references in the diff.
There was a problem hiding this comment.
leftover from copy/paste; fixed
This was a temporary hack needed until kgateway-dev#10499 landed in main. Signed-off-by: timflannagan <timflannagan@gmail.com>
Prepares the envoyinit component for removal of
projects/glooStill needs work, notably: #10491