Makefile: Remove security scan targets #10580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit rips out the security scan related Makefile targets. The docs/cmd/generate_docs.go file no longer exists in the repository after kgateway-dev#10576 merged to main. Additionally, the scan-version target no longer works as the github.com/solo-io/go-utils/securityscanutils/cli tool hangs when scanning the kgateway images. Signed-off-by: timflannagan <timflannagan@gmail.com>
timflannagan
force-pushed
the
chore/remove-scan-targets
branch
from
8ed3095 to
07eb8b0
Compare
jenshu
approved these changes
Feb 5, 2025
|
@timflannagan do we have a tracking issue for figuring out how security scanning will work going forward? |
stevenctl
pushed a commit
to stevenctl/gloo
that referenced
this pull request
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit rips out the security scan related
Makefile targets. The docs/cmd/generate_docs.go file no longer exists in the repository after #10576 merged to main.
Additionally, the scan-version target no longer works as the github.com/solo-io/go-utils/securityscanutils/cli tool hangs when scanning the kgateway images.
Checklist: