[DROOLS-4636] Update Scenario Cheatsheet to mention MVEL and Background #1277
Conversation
| @@ -189,3 +189,6 @@ validationSucceed=Validation Succeed | |||
|
|
|||
| backgroundTabTitle=Background | |||
| backgroundErrorNotification=There are errors in Background data, please have a look | |||
| ruleCheatSheet23=To specify a MVEL expression (or invoke a Java method) just put # at the beginning of the expression. In GIVEN section, return type of the expression has to be the same one of type of the column. In EXPECT section the type could also just a boolean with the result of the assertion and you can use actualValue identifier to access value to check. | |||
| ruleCheatSheetBackground=If the same GIVEN data is shared by multiple test scenarios, you can use the Background tab to define them once. You can create a column in Background in the same way of Model | |||
| @@ -189,3 +189,6 @@ validationSucceed=Validation Succeed | |||
|
|
|||
| backgroundTabTitle=Background | |||
| backgroundErrorNotification=There are errors in Background data, please have a look | |||
| ruleCheatSheet23=To specify a MVEL expression (or invoke a Java method) just put # at the beginning of the expression. In GIVEN section, return type of the expression has to be the same one of type of the column. In EXPECT section the type could also just a boolean with the result of the assertion and you can use actualValue identifier to access value to check. | |||
| ruleCheatSheetBackground=If the same GIVEN data is shared by multiple test scenarios, you can use the Background tab to define them once. You can create a column in Background in the same way of Model | |||
| dmnCheatSheetBackground=If the same GIVEN data is shared by multiple test scenarios, you can use the Background tab to define them once. You can create a column in Background in the same way of Model. | |||
There was a problem hiding this comment.
If dmnCheatSheetBackground and ruleCheatSheetBackground are the same cannot we have only one?
There was a problem hiding this comment.
@danielezonca I agree with @dupliaka, I suggest to define a separate method (eg. setCommonCheatSheetContent()) where shared descriptions are set in one single point and with a single property definition, in order to avoid text duplication.
There was a problem hiding this comment.
I have removed the duplication (commonCheatSheetBackground) but I prefer not to refactor the whole method to create a setCommonCheatSheetContent because the structure of the HTML is different. To do that we should refactor the whole panel
There was a problem hiding this comment.
Also since we discussed it with you @danielezonca the dmn and drl bkg are not the same;
So drl can use it as a batch update but dmn can not and dmn would take only last record of it
| @@ -189,3 +189,6 @@ validationSucceed=Validation Succeed | |||
|
|
|||
| backgroundTabTitle=Background | |||
| backgroundErrorNotification=There are errors in Background data, please have a look | |||
There was a problem hiding this comment.
Are you sure that we shell mention all of the limitation for expressions?
Bcs we are obviosly do not mention that if you will /0 the expression will fall, why should we mention about the return type? Just my feeling of the cheat sheet idea. I would like to only mention a key words.
# specifies expression you can use to invoke Java code.
actualValue specifies parameter for assertion in EXPECT.
But if you have other ideas...
If you really want to leave it here a shorten version of it as well:
Return type of the expression in GIVEN section should be the same as type of the column.
Return type of the expression in EXPECT section should be boolean assertion result.
There was a problem hiding this comment.
I can remove the additional information but I think it could be useful to have them here. I cannot user your suggested version because in EXPECT expression can return the same type (and in this case it will be verified as == to the actualValue) or a boolean so I mentioned both
There was a problem hiding this comment.
Ok, what about using /expression? Coz we are no need to put # before the expression for those column.
|
jenkins retest this please |
|
Hey @danielezonca, Just some minor suggestions: In rule-based: Updated: If the same GIVEN data is shared with the multiple test scenarios, you can use the Background tab to define them only once. The way to create a column in the Background tab is the same as of the Model tab. |
|
Kudos, SonarCloud Quality Gate passed!
|
@yesamer @dupliaka @kaldesai
DMN
RULE
https://issues.redhat.com/browse/DROOLS-4636