Skip to content
This repository has been archived by the owner on Jun 29, 2022. It is now read-only.

Remove Deprecated CoreOS from Bare Metal terraform #1246

Merged
merged 1 commit into from
Dec 8, 2020
Merged

Remove Deprecated CoreOS from Bare Metal terraform #1246

merged 1 commit into from
Dec 8, 2020

Conversation

karlskewes
Copy link
Contributor

@karlskewes karlskewes commented Dec 5, 2020

After starting found this commit which is almost the same.

$ go test
PASS
ok      github.com/kinvolk/lokomotive/pkg/platform/baremetal    0.020s

@karlskewes karlskewes changed the title Remove Deprecated CoreOS from Bare Metal terraform WIP: Remove Deprecated CoreOS from Bare Metal terraform Dec 5, 2020
@karlskewes
Copy link
Contributor Author

Sorry pushed a bit quick. Have built new lokoctl exec and currently validating behaviour with bare-metal (libvirtd) cluster, config via matchbox.

@karlskewes
Copy link
Contributor Author

Have run in to #1191. Otherwise seems fine. Investigating.

- remove CoreOS from terraform, closing #324
- unify `os_channel` on bare-metal, closing #445
@karlskewes karlskewes changed the title WIP: Remove Deprecated CoreOS from Bare Metal terraform Remove Deprecated CoreOS from Bare Metal terraform Dec 7, 2020
Copy link
Member

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm testing it manually on separate CI pipeline.

@invidian
Copy link
Member

invidian commented Dec 8, 2020

CI is passing and I no longer see syntax deprecation warnings 🎉 Thanks a lot for your contribution @kskewes!

@invidian invidian merged commit b73f04c into kinvolk:master Dec 8, 2020
@karlskewes karlskewes deleted the rm-bm-coreos branch December 8, 2020 16:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants