Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Inline Footer #958

Closed
8 of 13 tasks
bommariusser opened this issue Mar 17, 2020 · 5 comments · Fixed by #1982
Closed
8 of 13 tasks

[Enhancement] Inline Footer #958

bommariusser opened this issue Mar 17, 2020 · 5 comments · Fixed by #1982
Assignees

Comments

@bommariusser
Copy link
Contributor

bommariusser commented Mar 17, 2020

Is your enhancement request related to a problem? Please describe.
On pages without that much content, our buttons (and other content, like text and links) are hard to place in the very bottom of the content of the page/modal.

Describe the solution
A way to either wrap or mark elements that should be pushed to very bottom of the content.

Skærmbillede 2020-03-17 kl  11 16 38

See guidelines for Inline footer:
image

Tasks

Kick Off:

  • Ensure the enhancement is UX refined and aligned with UX
    The component and/or enhancement should be published and available in the Kirby Styleguide on Zeplin
  • Ensure the enhancement has been Tech refined with @kirbydesign/kirby-guild and this issue is updated with a clear implementation description
    This issue should be in the Ready to do column of the Kirby kan-ban board before starting implementation)
  • Assign yourself to this issue and move it to the In progress column of the Kirby kan-ban board

Code:

  • Create Feature Branch from master branch
  • Create a draft implementation and push to Github
  • Ask a member of @kirbydesign/kirby-guild for a WIP review by creating a draft Pull Request
  • Implement unit tests
  • Update Cookbook Examples and Showcase, i.e. see Radio
    Also remember to add any relevant new API documentation

Review:

  • UX review:
    • Ensure implementation is correct in relation to the UX design and the Kirby Styleguide on Zeplin
    • With UX agree on the version of the implementation
  • Code review:
    • Open a pull request (or mark the existing draft PR as Ready for review) and ask @kirbydesign/kirby-guild for a review
      Remember to add closes #issueno to the description of the PR.
    • Once approved, merge feature branch/PR to master
  • Ask a member of @kirbydesign/kirby-guild to add a link to component showcase from Kirby Component Status and update the version number
@bommariusser bommariusser added enhancement New feature or request component:Modal component:Page NOT UX refined NOT Tech refined Needs Tech kickoff - solution outlined and agreed NOT Prioritized Issue not yet prioritized and added to a Milestone labels Mar 17, 2020
@bommariusser bommariusser added this to the Milestone 1 - 2020 milestone Mar 17, 2020
@JoanJensenBD JoanJensenBD added the T9 Issues needed by Team 9 label Dec 9, 2020
@bommariusser
Copy link
Contributor Author

See also https://zpl.io/2yNLddK

@jakobe jakobe removed the NOT Tech refined Needs Tech kickoff - solution outlined and agreed label Dec 18, 2020
@labanos labanos removed the NOT Prioritized Issue not yet prioritized and added to a Milestone label Jan 26, 2021
@alxzak alxzak changed the title [Enhancement] Inline Footer [Blocked][Enhancement] Inline Footer Mar 22, 2021
@alxzak alxzak changed the title [Blocked][Enhancement] Inline Footer [Enhancement] Inline Footer Mar 22, 2021
@jakobe
Copy link
Collaborator

jakobe commented Mar 25, 2021

Tech refinement: We need to alter the layout of the modal to be able to use plan flex-box for positioning the inline footer.

@NikolajSkousen
Copy link
Contributor

:)

@alxzak alxzak added this to Kirby Jan 11, 2022
@alxzak alxzak moved this to Review in progess in Kirby Jan 11, 2022
@MadsBuchmann MadsBuchmann moved this from Review in progess to Impeeded in Kirby Jan 17, 2022
@alxzak alxzak modified the milestones: M10 (x - 26/1 ), M11 ( 27/1 - 6/4 ) Jan 20, 2022
Repository owner moved this from 💤 Impeeded to ✅ Done in Kirby Feb 10, 2022
@MadsBuchmann
Copy link
Contributor

Accidentally closed

@MadsBuchmann MadsBuchmann reopened this Feb 10, 2022
@MadsBuchmann MadsBuchmann moved this from ✅ Done to 🟢 Ready for next release in Kirby Feb 10, 2022
@MadsBuchmann
Copy link
Contributor

Has been solved (#1982) and released! (#2048)

Repository owner moved this from 🟢 Ready for next release to ✅ Done in Kirby Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
9 participants