-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release version 5.1 #2048
Merged
Merged
Release version 5.1 #2048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Only redraw chart if its rendered * ♻️ Spy on 'updateLabels' instead of 'updateDataLabels' updateDataLabels was renamed to updateLabels in PR #1989. * Updated chart property name & tests Co-authored-by: Tobias Secher <bdytos@bankdata.dk> Co-authored-by: Mads Buchmann Frederiksen <mbf@prochimp.dk>
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.13.3 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.13.3...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: RasmusKjeldgaard <rkk@bankdata.dk>
Bumps [log4js](https://github.com/log4js-node/log4js-node) from 6.3.0 to 6.4.0. - [Release notes](https://github.com/log4js-node/log4js-node/releases) - [Changelog](https://github.com/log4js-node/log4js-node/blob/master/CHANGELOG.md) - [Commits](log4js-node/log4js-node@v6.3.0...v6.4.0) --- updated-dependencies: - dependency-name: log4js dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: RasmusKjeldgaard <rkk@bankdata.dk>
Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.22 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](ai/nanoid@3.1.22...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: RasmusKjeldgaard <rkk@bankdata.dk>
Bumps [ssri](https://github.com/npm/ssri) from 6.0.1 to 6.0.2. - [Release notes](https://github.com/npm/ssri/releases) - [Changelog](https://github.com/npm/ssri/blob/v6.0.2/CHANGELOG.md) - [Commits](npm/ssri@v6.0.1...v6.0.2) --- updated-dependencies: - dependency-name: ssri dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: RasmusKjeldgaard <rkk@bankdata.dk>
This is to avoid new consumers of Kirby taking grid into use. Co-authored-by: RasmusKjeldgaard <rkk@bankdata.dk>
* 💄 Introduce mixins for shadow and rounded corners * 💄 Apply rounded corners and shadow to list * 📝 Create list-experimental showcase * 💄 Rework and rename mixins and global classes * 💄 Enable first/last item padding in list * 📝 Add examples for declarative list * 📝 Refactor examples for use in showcase * 📝 Correct attribute for section header examples * 📝 Add examples to showcase * ♻️ Use section instead of ion-list Ion-list was not used for any specfic reason, and did not add any necessary functionality, so it has been exchanged for a section for now. * 📝 Improve documentation * ♻️ Rename slot for header to be more generic * ✅ Add tests for list-experimental * ✅ Remove focus flag from list-experimental suite * ✅ Add tests for padding top and bottom on item * 📝 Use correct name for slot in showcase * 📝 Add headings to example * ✅ Remove focus flag from item test * 📝 Improve wording and structure of showcase * 📝 Add multiple sections description to showcase * ✅ Use ' instead of " in test * Combine width style props into one in example Co-authored-by: Jesper Kaltoft Vind <git@jesperkaltoft.dk> * 🐛 Fix scss style for list example * 💄 Move utility classes to own list scss module * 💄 Apply refactored style classes to list * ✅ Remove unnecessary wrapper div from list Co-authored-by: Mads Buchmann Frederiksen <mbf@prochimp.dk> Co-authored-by: Jesper Kaltoft Vind <git@jesperkaltoft.dk>
* updated modal-footer component ts, scss and corresponding tests. Updated showcase component. * corrected test * rephrased description * Change type inline/fixed * removed f in fdescribe, refactor of hostbinding
MadsBuchmann
approved these changes
Feb 14, 2022
jkaltoft
approved these changes
Feb 14, 2022
This was referenced Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Bugfixes
chart - only redraw chart on input changes if it has been rendered at least once (#2017)
Features
list-experimental - add rounded corners and shadow to list (#2029)
modal - Added
type
input property for inline kirby-modal-footer style (#1982)