Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify library structure to support web components #1402

Merged
merged 145 commits into from
Nov 1, 2021
Merged

Modify library structure to support web components #1402

merged 145 commits into from
Nov 1, 2021

Conversation

flemcito
Copy link
Contributor

@flemcito flemcito commented Mar 12, 2021 •
edited by RasmusKjeldgaard
Loading

This PR closes #1315

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

A major restructuring of the repo.

  • Introducing the @kirbydesign/core package.
  • Bugfix
  • Feature
  • Enhancement (to existing content)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • cookbook application / infrastructure changes
  • Other... Please describe:

Which issue documents the current behaviour?

Issue Number: #[replace with issue number]

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@flemcito
stencil scaffold
679d4a7
@flemcito
mocks
5d6f64f
@flemcito
Merge branch 'master' into enhancement/web-components
a944968
@flemcito
Update mock-components.ts
d96bc19
@flemcito
First spike
7db9dd2
@flemcito
with gitignore
f0c35e0
@flemcito
Merge branch 'master' into enhancement/web-components
442d9dc
@flemcito
deleted old badge
eed6ff1
@flemcito
Update mock-components.ts
e10bead
@flemcito
removed ref to old badge
c7ac706
@flemcito
Update mock-components.ts
2ffc76f
@flemcito
trying to get test to work
d637b3f
@flemcito
Update mock-components.ts
ab2d40c
@flemcito
Merge branch 'master' into enhancement/web-components
7ae4b93
@flemcito
Update mock-components.ts
9c6c1eb
@flemcito
built new core
8e6a272
@flemcito
Update mock-components.ts
7b625a6
@flemcito
cleanup config
cb4acea
@flemcito
Update mock-components.ts
d74a21f
@flemcito
test experiments
0f975fc
@flemcito
Update mock-components.ts
ee72157
@flemcito
exclude specs in tsconfig
d9a29b6
@flemcito
Update mock-components.ts
abb6493
@flemcito
link core
ee86bf9
@flemcito
Update mock-components.ts
f956717
@flemcito
Merge branch 'master' into enhancement/web-components
fcb12e0
@flemcito
Update mock-components.ts
01a41b9
@flemcito
Fixed e-2-e tests
08a9f11
@flemcito
bump node version in ci
9d84d3f
@flemcito
node version on ci
25dcea1
RasmusKjeldgaard and others added 14 commits October 29, 2021 14:39
@RasmusKjeldgaard
🎨 Update prettier config and run prettier
5fd6eec
@RasmusKjeldgaard
⬆️ Bump version to match actual version on npm
a5e8cf9
@RasmusKjeldgaard
💄 Set default z-index for badge to auto
8604568
@RasmusKjeldgaard
💄 Use size token for badge size and border radius
d1537c2
@RasmusKjeldgaard
🔥 Remove test file - was just for experimenting
17aa25e
@RasmusKjeldgaard
Merge branch 'master' into enhancement/web-components
6b85e9c
@RasmusKjeldgaard
🚚 Move print styles to core
66ed5ba
@RasmusKjeldgaard
🚚 Rename appInitializer and dont export function
f60dd9a
@RasmusKjeldgaard
🔧 Remove umdModuleID from ng-package
c99f270 
It is redundant, as ng-packagr will infer this on its own
@RasmusKjeldgaard
💄 Create z-index variable for badge in avatar
b074aab
@RasmusKjeldgaard
💄 Use segmentBadge correctly so it evaluates
eba2ca9
@RasmusKjeldgaard
🚨 reference customElementsInitializer correctly
b86ca24
@RasmusKjeldgaard @MadsBuchmann
🎨 Add imports to same line
01fade4 
Co-authored-by: Mads Buchmann Frederiksen <mbf@prochimp.dk>
@RasmusKjeldgaard @MadsBuchmann
🎨 Make imports one line
c90f601 
Co-authored-by: Mads Buchmann Frederiksen <mbf@prochimp.dk>
@github-actions github-actions bot temporarily deployed to pr-web-components October 29, 2021 16:12 Inactive
@MadsBuchmann MadsBuchmann mentioned this pull request Nov 1, 2021
Closed
8 tasks
MadsBuchmann
MadsBuchmann previously approved these changes Nov 1, 2021
View reviewed changes
Copy link
Contributor

@MadsBuchmann MadsBuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an honor to finally be able to write these four letters with accompanying gif:

LGTM!
Happy Coder

@RasmusKjeldgaard RasmusKjeldgaard merged commit c2d8c4c into master Nov 1, 2021
@RasmusKjeldgaard RasmusKjeldgaard deleted the enhancement/web-components branch November 1, 2021 14:28
@RasmusKjeldgaard RasmusKjeldgaard mentioned this pull request Oct 10, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RasmusKjeldgaard RasmusKjeldgaard RasmusKjeldgaard left review comments

@jkaltoft jkaltoft jkaltoft left review comments

@MadsBuchmann MadsBuchmann MadsBuchmann approved these changes

Assignees

@RasmusKjeldgaard RasmusKjeldgaard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] Web Components: Create new lib structure for StencilJS
4 participants
@flemcito @RasmusKjeldgaard @jkaltoft @MadsBuchmann