Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use kirby-color for text in ion-content #2035

Closed
wants to merge 3 commits into from
Closed

Use kirby-color for text in ion-content #2035

wants to merge 3 commits into from

Conversation

jkaltoft
Copy link
Collaborator

@jkaltoft jkaltoft commented Feb 4, 2022

Which issue does this PR close?

This PR closes #2033

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be automatically merged to master via automerge.

@github-actions github-actions bot temporarily deployed to pr-2033-font-color-black-instead-of-kirby-black February 4, 2022 12:07 Inactive
@github-actions github-actions bot temporarily deployed to pr-2033-font-color-black-instead-of-kirby-black February 10, 2022 09:17 Inactive
@jkaltoft jkaltoft force-pushed the bugfix/2033-font-color-black-instead-of-kirby-black branch from 7ac996c to 485643c Compare April 7, 2022 11:31
@github-actions github-actions bot temporarily deployed to pr-2033-font-color-black-instead-of-kirby-black April 7, 2022 11:32 Inactive
@github-actions github-actions bot temporarily deployed to pr-2033-font-color-black-instead-of-kirby-black April 7, 2022 11:35 Inactive
@jkaltoft jkaltoft force-pushed the main branch 2 times, most recently from 92bab4d to d2857a1 Compare April 22, 2022 13:06
@stale
Copy link

stale bot commented Aug 3, 2022

This pull request has been automatically marked as stale because of no recent activity. It will be closed in 10 weeks if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Automatically applied when there is no activity on an issue or PR label Aug 3, 2022
@jkaltoft jkaltoft removed the stale Automatically applied when there is no activity on an issue or PR label Aug 8, 2022
@jkaltoft
Copy link
Collaborator Author

Fixed by #2520

@jkaltoft jkaltoft closed this Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Font color is black instead of kirby-black
1 participant
@jkaltoft