Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using kirby black on ion-tool bar and ion-content instead of using black #2520

Merged

Conversation

AgreSanGit
Copy link
Contributor

@AgreSanGit AgreSanGit commented Oct 4, 2022

Which issue does this PR close?

This PR closes #2033

What is the new behavior?

Now using kirby black for page-title and toolbar instead of black

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@AgreSanGit AgreSanGit marked this pull request as ready for review October 4, 2022 10:39
@AgreSanGit AgreSanGit requested a review from jkaltoft as a code owner October 4, 2022 10:39
@AgreSanGit AgreSanGit self-assigned this Oct 4, 2022
@github-actions github-actions bot temporarily deployed to pr-2033-font-color-is-black-instead-of-kirby-black-v2 October 4, 2022 10:43 Inactive
Copy link
Collaborator

@jkaltoft jkaltoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Make sure to get this UX reviewed before merging.

@henrikvoetmand
Copy link
Collaborator

UX review done! OK!

@AgreSanGit AgreSanGit merged commit d18e896 into develop Oct 7, 2022
@AgreSanGit AgreSanGit deleted the bug/2033-font-color-is-black-instead-of-kirby-black-v2 branch October 7, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Font color is black instead of kirby-black
3 participants