Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Modal closeButton and supplementaryButton too small #2350

Closed
1 of 9 tasks
RasmusKjeldgaard opened this issue Jun 15, 2022 · 0 comments · Fixed by #2352 or #2372
Closed
1 of 9 tasks

[BUG] Modal closeButton and supplementaryButton too small #2350

RasmusKjeldgaard opened this issue Jun 15, 2022 · 0 comments · Fixed by #2352 or #2372

Comments

@RasmusKjeldgaard
Copy link
Collaborator

Describe the bug

After #2245 was implemented, it seems that the modal buttons where not updated to the correct size.
It should be size md according to zeplin: https://zpl.io/z89qQl7.
image

Describe how to reproduce the bug

Replace this with steps to reproduce the behavior:

  1. Go to https://cookbook.kirby.design/#/home/showcase/modal
  2. Click on 'show modal' button

Which Kirby version was used?

6.0.1


Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Verification

To make sure the bug is not intended behaviour; it should be verified by a member of team Kirby before moving on to implementation.

  • Make sure the NOT verified label has been removed by a member of team Kirby; do not proceed until this is done

Implementation

The contributor who wants to implement this issue should:

Review

Once the issue has been implemented and is ready for review:

@RasmusKjeldgaard RasmusKjeldgaard added bug NOT Prioritized Issue not yet prioritized and added to a Milestone NOT Verified Applied to bug reports that have not been verified by a member of @kirbydesign/kirby-guild labels Jun 15, 2022
@RasmusKjeldgaard RasmusKjeldgaard changed the title [BUG] Modal close and drawer collapse button too small [BUG] Modal closeButton and supplementaryButton too small Jun 15, 2022
@RasmusKjeldgaard RasmusKjeldgaard moved this to ✅ Done in Kirby Jun 27, 2022
@RasmusKjeldgaard RasmusKjeldgaard added 🟢 Ready for release and removed NOT Prioritized Issue not yet prioritized and added to a Milestone NOT Verified Applied to bug reports that have not been verified by a member of @kirbydesign/kirby-guild labels Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
1 participant