Reduce vertical padding on modal-header #2372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The close/supplementary button in the modal is now size 'md' and therefore the header became too large. The top/bottom padding has been reduced accordingly.
github-actions
bot
temporarily deployed
to
pr-2350-modal-button-too-small-followup
MadsBuchmann
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This PR closes #2350
What is the new behavior?
The close/supplementary button in the modal is now size 'md' and therefore the header became too large. The top/bottom padding has been reduced accordingly.
Does this PR introduce a breaking change?
Are there any additional context?
#2350 was originally solved by #2352, but this fix is also needed for the toolbar/header to have the correct total height.
Checklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Reminders
Review
When the pull request has been approved it will be merged to
developby Team Kirby.