Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change modal close + supplementaryButton to md #2352

Merged
merged 2 commits into from
Jun 15, 2022

Conversation

RasmusKjeldgaard
Copy link
Collaborator

Which issue does this PR close?

This PR closes #2350

What is the new behavior?

The icon for small buttons has been made smaller in #2245.

This means that the modal has unintentionally small buttons now, for the close icon and the supplementary button (e.g. the collapse button for the drawer.

Does this PR introduce a breaking change?

  • Yes
  • No

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@github-actions github-actions bot temporarily deployed to pr-2350-modal-button-too-small June 15, 2022 12:10 Inactive
@RasmusKjeldgaard RasmusKjeldgaard merged commit 5b85206 into develop Jun 15, 2022
@RasmusKjeldgaard RasmusKjeldgaard deleted the bug/2350-modal-button-too-small branch June 15, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Modal closeButton and supplementaryButton too small
2 participants