Deprecate standalone chip component #2391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
github-actions
bot
temporarily deployed
to
pr-2341-deprecate-standalone-chip-component
github-actions
bot
temporarily deployed
to
pr-2341-deprecate-standalone-chip-component
| @@ -7,6 +7,12 @@ import { ChangeDetectionStrategy, Component, HostBinding, Input } from '@angular | |||
| changeDetection: ChangeDetectionStrategy.OnPush, | |||
| }) | |||
| export class ChipComponent { | |||
| constructor() { | |||
| console.warn( | |||
| 'DEPRECATION WARNING: `<kirby-chip>` will be removed from the API in an upcoming major version of Kirby.' | |||
There was a problem hiding this comment.
Should we add a suggestion for migration to this issue? E.g. 'Use the kirby button component instead.'
| @@ -7,6 +7,12 @@ import { ChangeDetectionStrategy, Component, HostBinding, Input } from '@angular | |||
| changeDetection: ChangeDetectionStrategy.OnPush, | |||
| }) | |||
| export class ChipComponent { | |||
| constructor() { | |||
| console.warn( | |||
| 'DEPRECATION WARNING: `<kirby-chip>` will be removed from the API in an upcoming major version of Kirby.' | |||
There was a problem hiding this comment.
Suggested change
| 'DEPRECATION WARNING: `<kirby-chip>` will be removed from the API in an upcoming major version of Kirby.' | |
| 'DEPRECATION WARNING: `<kirby-chip>` will be removed from the API in Kirby v8.' |
Consider being more specific, I think it makes the message a bit more helpful.
RasmusKjeldgaard
approved these changes
Aug 1, 2022
RasmusKjeldgaard
approved these changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This PR closes #2341
What is the new behavior?
Does this PR introduce a breaking change?
Are there any additional context?
Checklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Reminders
Review
When the pull request has been approved it will be merged to
developby Team Kirby.