Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate standalone chip component #2391

Merged
merged 4 commits into from
Aug 5, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view

This file was deleted.

This file was deleted.

2 changes: 0 additions & 2 deletions apps/cookbook/src/app/examples/examples.common.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import { ButtonExampleComponent } from './button-example/button-example.componen
import { CalendarCardExampleComponent } from './calendar-example/calendar-card-example.component';
import { CalendarExampleComponent } from './calendar-example/calendar-example.component';
import { CheckboxExampleComponent } from './checkbox-example/checkbox-example.component';
import { ChipExampleComponent } from './chip-example/chip-example.component';
import { DividerExampleComponent } from './divider-example/divider-example.component';
import { EmptyStateExampleComponent } from './empty-state-example/empty-state-example.component';
import { ExamplesComponent } from './examples.component';
Expand Down Expand Up @@ -63,7 +62,6 @@ export const COMPONENT_DECLARATIONS: any[] = [
FontsExampleComponent,
SpinnerExampleComponent,
SegmentedControlExampleComponent,
ChipExampleComponent,
IconExampleComponent,
CalendarExampleComponent,
CalendarCardExampleComponent,
Expand Down
5 changes: 0 additions & 5 deletions apps/cookbook/src/app/examples/examples.routes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import { CalendarExampleComponent } from './calendar-example/calendar-example.co
import { CardExampleComponent } from './card-example/card-example.component';
import { ChartsExampleComponent } from './charts-example/charts-example.component';
import { CheckboxExampleComponent } from './checkbox-example/checkbox-example.component';
import { ChipExampleComponent } from './chip-example/chip-example.component';
import { EmptyStateExampleComponent } from './empty-state-example/empty-state-example.component';
import { ExamplesComponent } from './examples.component';
import { FabSheetExampleComponent } from './fab-sheet-example/fab-sheet-example.component';
Expand Down Expand Up @@ -365,10 +364,6 @@ export const routes: Routes = [
path: 'virtual-scroll-list',
component: VirtualScrollListExampleComponent,
},
{
path: 'chip',
component: ChipExampleComponent,
},
{
path: 'avatar',
component: AvatarExampleComponent,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,14 @@ const config = {
[selectedIndex]="selectedIndex"
(segmentSelect)="onSegmentSelect($event)"
></kirby-segmented-control>
<kirby-chip
[text]="separateSegment.text"
<button
kirby-button
size="sm"
[attentionLevel]="selectedSegment === separateSegment ? '2' : '3'"
(click)="onSegmentSelect(separateSegment)"
[isSelected]="selectedSegment === separateSegment">
</kirby-chip>
>
{{ separateSegment.text }}
</button>
</div>
<kirby-list [items]="filteredListItems">
<kirby-item *kirbyListItemTemplate="let item">
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

2 changes: 0 additions & 2 deletions apps/cookbook/src/app/showcase/showcase.common.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ import { CalendarShowcaseComponent } from './calendar-showcase/calendar-showcase
import { CardShowcaseComponent } from './card-showcase/card-showcase.component';
import { ChartShowcaseComponent } from './chart-showcase/chart-showcase.component';
import { CheckboxShowcaseComponent } from './checkbox-showcase/checkbox-showcase.component';
import { ChipShowcaseComponent } from './chip-showcase/chip-showcase.component';
import { ColorsShowcaseComponent } from './colors-showcase/colors-showcase.component';
import { EmptyStateShowcaseComponent } from './empty-state-showcase/empty-state-showcase.component';
import { FabSheetShowcaseComponent } from './fab-sheet-showcase/fab-sheet-showcase.component';
Expand Down Expand Up @@ -74,7 +73,6 @@ export const COMPONENT_EXPORTS: any[] = [
SpinnerShowcaseComponent,
ModalShowcaseComponent,
SegmentedControlShowcaseComponent,
ChipShowcaseComponent,
BadgeShowcaseComponent,
IconShowcaseComponent,
CalendarShowcaseComponent,
Expand Down
5 changes: 0 additions & 5 deletions apps/cookbook/src/app/showcase/showcase.routes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import { CalendarShowcaseComponent } from './calendar-showcase/calendar-showcase
import { CardShowcaseComponent } from './card-showcase/card-showcase.component';
import { ChartShowcaseComponent } from './chart-showcase/chart-showcase.component';
import { CheckboxShowcaseComponent } from './checkbox-showcase/checkbox-showcase.component';
import { ChipShowcaseComponent } from './chip-showcase/chip-showcase.component';
import { ColorsShowcaseComponent } from './colors-showcase/colors-showcase.component';
import { DividerShowcaseComponent } from './divider-showcase/divider-showcase.component';
import { DropdownShowcaseComponent } from './dropdown-showcase/dropdown-showcase.component';
Expand Down Expand Up @@ -90,10 +89,6 @@ export const routes: Routes = [
path: 'slide-button',
component: SlideButtonShowcaseComponent,
},
{
path: 'chip',
component: ChipShowcaseComponent,
},
{
path: 'divider',
component: DividerShowcaseComponent,
Expand Down
6 changes: 6 additions & 0 deletions libs/designsystem/src/lib/components/chip/chip.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@ import { ChangeDetectionStrategy, Component, HostBinding, Input } from '@angular
changeDetection: ChangeDetectionStrategy.OnPush,
})
export class ChipComponent {
constructor() {
console.warn(
'DEPRECATION WARNING: `<kirby-chip>` will be removed from the API in Kirby v8. Use the Kirby button component instead.'
);
}

@Input() text: string;

@Input()
Expand Down