Fix dropdown scroll problem on touch devices #2396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mictro
requested review from
jkaltoft and
RasmusKjeldgaard
and removed request for
jkaltoft
github-actions
bot
temporarily deployed
to
pr-2335-scrolling-swiping-in-dropdown-popout-list-on-native-devices-with-pull-to-refresh
RasmusKjeldgaard
requested changes
Aug 1, 2022
Comment on lines
239
to
242
| onTouchStart(event: TouchEvent): void { | ||
| // Prevent touchmove propgation to allow for scroll on page with pull-to-refresh; | ||
| event.stopPropagation(); | ||
| } |
There was a problem hiding this comment.
Consider replacing this with the following snippet.
I think it should result in identical behavior, and it uses a similar pattern to how we have done it for the keydown events in this component (bottom of this file). As an added bonus we should not need to add anything to the template.
@HostListener('touchstart', ['$event']) _onTouchStart(event: TouchEvent) {
event.stopPropagation();
}
c6e8346 to
0d5f9c6
Compare
github-actions
bot
temporarily deployed
to
pr-2335-scrolling-swiping-in-dropdown-popout-list-on-native-devices-with-pull-to-refresh
…pout-list-on-native-devices-with-pull-to-refresh
mictro
deleted the
bug/2335-scrolling-swiping-in-dropdown-popout-list-on-native-devices-with-pull-to-refresh
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This PR closes #2335
What is the new behavior?
Prevent page refresh when dropdown is scrolled on touch devices
Does this PR introduce a breaking change?
Are there any additional context?
Checklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Reminders
Review
When the pull request has been approved it will be merged to
developby Team Kirby.