Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dropdown scroll problem on touch devices #2396

Merged
merged 2 commits into from
Aug 4, 2022
Merged

Fix dropdown scroll problem on touch devices #2396

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d5f9c6
Fix dropdown scroll problem on touch devices
mictro Jul 25, 2022
39d0bc2
Merge branch 'develop' into bug/2335-scrolling-swiping-in-dropdown-po…
mictro Aug 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion libs/designsystem/src/lib/components/dropdown/dropdown.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ export class DropdownComponent implements AfterViewInit, OnDestroy, ControlValue
event.preventDefault();
}

/* Utility that makes it easier to set styles on card element
/* Utility that makes it easier to set styles on card element
when using popover*/
private setPopoverCardStyle(style: string, value: string) {
if (!this.usePopover) return;
Expand Down Expand Up @@ -463,6 +463,13 @@ export class DropdownComponent implements AfterViewInit, OnDestroy, ControlValue
}
}

@HostListener('touchstart', ['$event'])
_onTouchStart(event: TouchEvent) {
if (this.isOpen) {
event.stopPropagation();
}
}

@HostListener('focus')
_onFocus() {
if (this.disabled) {
Expand Down