Update dependencies #231
Closed
Update dependencies #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes errors like this: internal error: package "bytes" without types was imported from "command-line-arguments"
|
Looks like this doesn't pass the test suite.. |
|
It seems that newer version of golang.org/x/tools, which is absolutely required on the currently supported Golang versions 1.19 & 1.20, is not working on older Golang versions. And your test suite is not testing supported Golang versions at all, just older ones? Based on the fact that compile on Go 1.18.x went fine, you might consider to not support anything older than 1.18.x anymore? |
abhinav
added a commit
to abhinav/errcheck
that referenced
this pull request
May 31, 2023
Upgrades to the latest release of /x/tools and friends.
This is necessary to fix errors during `go test` similar to:
This fixes errors like this: internal error: package "bytes" without types was imported from "command-line-arguments"
Supersedes kisielk#231
kisielk
pushed a commit
that referenced
this pull request
Nov 2, 2023
* mod: Use latest /x/tools, use Go 1.18
Upgrades to the latest release of /x/tools and friends.
This is necessary to fix errors during `go test` similar to:
This fixes errors like this: internal error: package "bytes" without types was imported from "command-line-arguments"
Supersedes #231
* ci: Test against Go 1.18-1.20
Switch CI to only test against Go 1.18 to 1.20.
Per the Go support policy, only 1.19 and 1.20 are currently supported,
but I've left 1.18 in there to support stragglers.
To reduce duplication in the CI job, this also switches to a test matrix
instead of copy-pasting the steps between each job.
|
This was replaced by #234 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes errors like this: internal error: package "bytes" without types was imported from "command-line-arguments"