Update deps, test with latest Go #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrades to the latest release of /x/tools and friends.
This is necessary to fix errors during `go test` similar to:
This fixes errors like this: internal error: package "bytes" without types was imported from "command-line-arguments"
Supersedes kisielk#231
Switch CI to only test against Go 1.18 to 1.20. Per the Go support policy, only 1.19 and 1.20 are currently supported, but I've left 1.18 in there to support stragglers. To reduce duplication in the CI job, this also switches to a test matrix instead of copy-pasting the steps between each job.
abhinav
commented
May 31, 2023
kisielk
approved these changes
Nov 2, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Commits are individually reviewable.)
This PR does two things:
can run against the latest versions of Go
Note that per the upstream Go support policy,
only the latest two minor releases are supported.
So with Go 1.20 being the current release,
upstream only supports Go 1.19 and 1.20.
(Support in this context means that only these releases get bug fixes
and security fixes.)
This change leaves in support for 1.18 to ensure that errcheck keeps working
for any stragglers who haven't yet upgraded to at least 1.19,
but it drops testing against all older versions.
Supersedes #231