Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New docs #423

Merged
merged 29 commits into from
Nov 7, 2024
Merged

New docs #423

merged 29 commits into from
Nov 7, 2024

Conversation

sneridagh
Copy link
Member

No description provided.

davisagli
davisagli reviewed Oct 24, 2024
View reviewed changes
Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sneridagh Don't most of these new how-to docs belong in volto's docs rather than in volto-light-theme?

davisagli
davisagli reviewed Oct 28, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@sneridagh
Copy link
Member Author

sneridagh commented Nov 4, 2024 •
edited
Loading

@davisagli I've amended the docs, so this PR should go first before #420 . Ready for your review!

davisagli
davisagli approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sneridagh Basically looks good to me.

docs/install.md Outdated Show resolved Hide resolved
@stevepiercy
Add robots.txt with Sitemap URL
b56f64d
@stevepiercy
Remove unused static files
e8ee223
@stevepiercy
Tidy up index.md. There's still a lot of switching between passive an…
8a43d21 
…d active voices, as well as "we" and "you", but I don't have the energy to go through it all. There's also some marketing stuff that I don't want to touch.
@stevepiercy
Tidy up install.md
0a6d4fe
@stevepiercy
Remove unnecessary extensions, builders, configuration from conf.py
dbf876b
@stevepiercy
Add meta html stuff, and tidy up install.md
6e8c89f
@stevepiercy
Make screenshot clickable for full size
37762c1
@stevepiercy
Tidy up feature-flags.md
12a0b3a
@stevepiercy
Tidy up contributing.md
657d86a
@stevepiercy
Tidy up upgrade-guide.md
c4fc48a
@stevepiercy
Tidy up block-model-v3.md
452c306
@stevepiercy
Tidy up compatibility.md
ad60100
@stevepiercy
Revert "Tidy up compatibility.md"
0f060cb 
This reverts commit ad60100.
@stevepiercy
Tidy up compatibility.md
1def058
@stevepiercy
Tidy up releases.md
a641e03
@stevepiercy
Synch Vision statements
446b9e6
@stevepiercy
Fix myst topmatter
ea013a8
@stevepiercy
Fix broken links
3c16fd7
stevepiercy
stevepiercy requested changes Nov 7, 2024
View reviewed changes
docs/conf.py Outdated Show resolved Hide resolved
docs/compatibility.md Outdated Show resolved Hide resolved
docs/conf.py Outdated Show resolved Hide resolved
docs/contributing.md Outdated Show resolved Hide resolved
stevepiercy
stevepiercy approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review by pushing commits. I left a few comments for consideration. Otherwise it is good to merge, and we can check RTD to verify it works.

@sneridagh sneridagh merged commit a7a990f into main Nov 7, 2024
26 checks passed
@sneridagh sneridagh deleted the newdocs branch November 7, 2024 11:48
@sneridagh
Copy link
Member Author

@stevepiercy thanks!!

sneridagh added a commit that referenced this pull request Nov 7, 2024
@sneridagh
Merge branch 'main' into vlt6
dc62d04 
* main:
  New docs (#423)
@stevepiercy
Copy link
Collaborator

Let's verify that the home page URL is correct.

https://volto-light-theme.readthedocs.io/

https://volto-light-theme.readthedocs.io/sitemap.xml

https://volto-light-theme.readthedocs.io/robots.txt

Oopsie, one mistake. PR incoming. No changelog needed.

stevepiercy added a commit that referenced this pull request Nov 7, 2024
@stevepiercy
Fix the URL to the sitemap as part of #423
2d76054 
No change log needed.
davisagli pushed a commit that referenced this pull request Nov 7, 2024
@stevepiercy
Fix the URL to the sitemap as part of #423 (#429)
18c9fba
sneridagh added a commit that referenced this pull request Nov 11, 2024
@sneridagh
Merge branch 'vlt6' into addlayersinvlt6
0072fe3 
* vlt6:
  Remove leaked customization file for adding layers PR
  Fix schema for image block
  Fix the URL to the sitemap as part of #423 (#429)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevepiercy stevepiercy stevepiercy approved these changes

@davisagli davisagli davisagli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sneridagh @stevepiercy @davisagli