Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the URL to the sitemap as part of #423 #429

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Conversation

stevepiercy
Copy link
Collaborator

@stevepiercy stevepiercy commented Nov 7, 2024

No change log needed.


📚 Documentation preview 📚: https://volto-light-theme--429.org.readthedocs.build/

@stevepiercy
Copy link
Collaborator Author

If https://volto-light-theme--429.org.readthedocs.build/robots.txt contains the correct URL of https://volto-light-theme.readthedocs.io/sitemap.xml in RTD, then this passes.

@stevepiercy
Copy link
Collaborator Author

meh, nevermind, I forgot that RTD uses its own robots.txt, so we can't verify it until it merges and builds.

We'll need to look at:

https://volto-light-theme.readthedocs.io/robots.txt

@stevepiercy
Copy link
Collaborator Author

I'm just going to merge it, and see what happens.

@stevepiercy
Copy link
Collaborator Author

No I'm not, I lack sufficient permission. Up to you @sneridagh. lol.

@davisagli davisagli merged commit 18c9fba into main Nov 7, 2024
26 of 27 checks passed
@davisagli davisagli deleted the fix-url-to-sitemap branch November 7, 2024 19:09
@davisagli
Copy link
Member

@stevepiercy I can't tell whether it deployed to RTD after merging or not.

@stevepiercy
Copy link
Collaborator Author

@davisagli it did https://volto-light-theme.readthedocs.io/robots.txt and it has the correct URL now:

Sitemap: https://volto-light-theme.readthedocs.io/sitemap.xml

...which in turn resolves to the sitemap. You got SEO! Let the visits counter soar!

@davisagli
Copy link
Member

@stevepiercy thanks!

sneridagh added a commit that referenced this pull request Nov 11, 2024
* vlt6:
  Remove leaked customization file for adding layers PR
  Fix schema for image block
  Fix the URL to the sitemap as part of #423 (#429)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants