Support VCR.py >=5 (fixes #111) #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #118 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 283 287 +4
Branches 54 54
=========================================
+ Hits 283 287 +4
☔ View full report in Codecov by Sentry. |
.. and allow for convenient "pip install -e .[test]".
hartwork
force-pushed
the
issue-111-support-vcrpy-5
branch
from
06cc9db
to
369c13b
Compare
|
Awesome! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partial pull request for support for VCR.py >=5 as offered at #111 (comment) . I lack the bandwidth to re-write the two tests marked as "todo" at the moment, but I should find time for smaller adjustments/additions that come up during review. Thanks for your understanding.
Checklist
Fixes #111
CC @Stranger6667