Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise in patch_hint if hint is not found #1304

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Raise in patch_hint if hint is not found #1304

merged 1 commit into from
Jul 25, 2024

Conversation

ClementWalter
Copy link
Member

@ClementWalter ClementWalter commented Jul 24, 2024 •
edited
Loading

Time spent on this PR: 0.05

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

No raise if hint is not found

Now raises if the patch doesn't do anything

This change is Reviewable

@ClementWalter ClementWalter merged commit d94a1bf into kkrt-labs:main Jul 25, 2024
6 checks passed
@ClementWalter ClementWalter deleted the cw/raise-patch-hint branch July 25, 2024 07:55
@ClementWalter ClementWalter mentioned this pull request Sep 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obatirou obatirou obatirou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ClementWalter @obatirou