Fix RLP.decode #1307
Merged
Fix RLP.decode #1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Serialize RLP.Item and refactor tests
enitrat
previously approved these changes
Jul 25, 2024
ClementWalter
force-pushed
the
cw/fix-rlp
branch
from
2fc1db4
to
36eef12
Compare
ClementWalter
force-pushed
the
cw/fix-rlp
branch
from
f8aa285
to
b54f21a
Compare
enitrat
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
RLP.decodedoesn't check that the result is consistent with the given len prefix.In other words, given two encoded items
b1andb2,RLP.decode(b1 + b2)will actually decodeb1andb2while it should raise becauseb1 + b2is not a valid RLP (it's a list with missing prefix).Resolves #1306
What is the new behavior?
This change is