Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: validate signature values #1331

Merged
merged 4 commits into from
Aug 8, 2024

Conversation

obatirou
Copy link
Collaborator

@obatirou obatirou commented Aug 6, 2024

Time spent on this PR:

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves #1325

What is the new behavior?

Signature values are checked to be < 2**128


This change is Reviewable

@obatirou obatirou force-pushed the oba/validate-signature-values branch from 5e32a37 to edede54 Compare August 6, 2024 19:27
@obatirou obatirou marked this pull request as ready for review August 7, 2024 07:34
Copy link
Collaborator

@enitrat enitrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

tests/src/kakarot/accounts/test_account_contract.py Outdated Show resolved Hide resolved
tests/src/kakarot/accounts/test_account_contract.py Outdated Show resolved Hide resolved
@obatirou obatirou force-pushed the oba/validate-signature-values branch from edede54 to 10d0dd5 Compare August 7, 2024 14:16
@obatirou obatirou merged commit 7fb90d7 into kkrt-labs:main Aug 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: AccountContract::validate is not validating the values used to construct the r and s signature values
2 participants