Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIx venv not cached in CI #1361

Merged

Conversation

ClementWalter
Copy link
Member

@ClementWalter ClementWalter commented Aug 26, 2024

Time spent on this PR: 0.1

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Venv is not cached in CI jobs and takes ~3 minutes to be rebuilt

What is the new behavior?

Path .venv set explicitly. Venv is cached.
Removed deprecated installer.modern-installation false config

See also : https://github.com/snok/install-poetry/tree/v1/


This change is Reviewable

@ClementWalter
Copy link
Member Author

image

@ClementWalter ClementWalter merged commit a6cb462 into kkrt-labs:main Aug 26, 2024
5 of 6 checks passed
@ClementWalter ClementWalter deleted the cw/fix-poetry-venv-cache branch August 26, 2024 08:22
matthieuauger pushed a commit to matthieuauger/kakarot that referenced this pull request Nov 9, 2024
* feat: add blockscout conf to docker-compose

* fix: network

* fix: ETHEREUM_JSONRPC_TRACE_URL

* feat: add blockscout to docker-compose.prod

* feat: add blockscout to staging

* feat: update readme with blockscout info
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants